blob: 929b33d99875c8557817dd2f238ec83421c03626 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
|
// RUN: %check_clang_tidy %s cppcoreguidelines-owning-memory %t
namespace gsl {
template <typename T>
using owner = T;
}
namespace std {
// Not actually a vector, but more a dynamic, fixed size array. Just to demonstrate
// functionality or the lack of the same.
template <typename T>
class vector {
public:
vector(unsigned long size, T val) : data{new T[size]}, size{size} {
for (unsigned long i = 0ul; i < size; ++i) {
data[i] = val;
}
}
T *begin() { return data; }
T *end() { return &data[size]; }
T &operator[](unsigned long index) { return data[index]; }
private:
T *data;
unsigned long size;
};
} // namespace std
// All of the following codesnippets should be valid with appropriate 'owner<>' anaylsis,
// but currently the type information of 'gsl::owner<>' gets lost in typededuction.
int main() {
std::vector<gsl::owner<int *>> OwnerStdVector(100, nullptr);
// Rangebased looping in resource vector.
for (auto *Element : OwnerStdVector) {
Element = new int(42);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: assigning newly created 'gsl::owner<>' to non-owner 'int *'
}
for (auto *Element : OwnerStdVector) {
delete Element;
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead
// CHECK-MESSAGES: [[@LINE-3]]:8: note: variable declared here
}
// Indexbased looping in resource vector.
for (int i = 0; i < 100; ++i) {
OwnerStdVector[i] = new int(42);
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: assigning newly created 'gsl::owner<>' to non-owner 'int *'
}
for (int i = 0; i < 100; ++i) {
delete OwnerStdVector[i];
// CHECK-MESSAGES: [[@LINE-1]]:5: warning: deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead
// A note gets emitted here pointing to the return value of the operator[] from the
// vector implementation. Maybe this is considered misleading.
}
return 0;
}
|
