blob: f3f1a1d8537e113a72e0cc4d9ff357f8cdca7575 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
|
// RUN: %check_clang_tidy %s bugprone-signed-char-misuse %t
///////////////////////////////////////////////////////////////////
/// Test cases correctly caught by the check.
int SimpleVarDeclaration() {
signed char CCharacter = -5;
int NCharacter = CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int SimpleAssignment() {
signed char CCharacter = -5;
int NCharacter;
NCharacter = CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int CStyleCast() {
signed char CCharacter = -5;
int NCharacter;
NCharacter = (int)CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:21: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int StaticCast() {
signed char CCharacter = -5;
int NCharacter;
NCharacter = static_cast<int>(CCharacter);
// CHECK-MESSAGES: [[@LINE-1]]:33: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int FunctionalCast() {
signed char CCharacter = -5;
int NCharacter;
NCharacter = int(CCharacter);
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int NegativeConstValue() {
const signed char CCharacter = -5;
int NCharacter = CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
int CharPointer(signed char *CCharacter) {
int NCharacter = *CCharacter;
// CHECK-MESSAGES: [[@LINE-1]]:20: warning: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
return NCharacter;
}
///////////////////////////////////////////////////////////////////
/// Test cases correctly ignored by the check.
int UnsignedCharCast() {
unsigned char CCharacter = 'a';
int NCharacter = CCharacter;
return NCharacter;
}
int PositiveConstValue() {
const signed char CCharacter = 5;
int NCharacter = CCharacter;
return NCharacter;
}
// singed char -> integer cast is not the direct child of declaration expression.
int DescendantCast() {
signed char CCharacter = 'a';
int NCharacter = 10 + CCharacter;
return NCharacter;
}
// singed char -> integer cast is not the direct child of assignment expression.
int DescendantCastAssignment() {
signed char CCharacter = 'a';
int NCharacter;
NCharacter = 10 + CCharacter;
return NCharacter;
}
// bool is an integer type in clang; make sure to ignore it.
bool BoolVarDeclaration() {
signed char CCharacter = 'a';
bool BCharacter = CCharacter == 'b';
return BCharacter;
}
// bool is an integer type in clang; make sure to ignore it.
bool BoolAssignment() {
signed char CCharacter = 'a';
bool BCharacter;
BCharacter = CCharacter == 'b';
return BCharacter;
}
// char is an integer type in clang; make sure to ignore it.
unsigned char CharToCharCast() {
signed char SCCharacter = 'a';
unsigned char USCharacter;
USCharacter = SCCharacter;
return USCharacter;
}
|
