blob: 08ea207d0174cc44d5e29655b9c9fa17d005e28a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
|
//===--- ElseAfterReturnCheck.cpp - clang-tidy-----------------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#include "ElseAfterReturnCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace readability {
void ElseAfterReturnCheck::registerMatchers(MatchFinder *Finder) {
// FIXME: Support continue, break and throw.
Finder->addMatcher(
compoundStmt(
forEach(ifStmt(hasThen(stmt(anyOf(returnStmt(),
compoundStmt(has(returnStmt()))))),
hasElse(stmt().bind("else")))
.bind("if"))),
this);
}
static FixItHint removeToken(SourceLocation Loc) {
return FixItHint::CreateRemoval(CharSourceRange::getTokenRange(Loc, Loc));
}
void ElseAfterReturnCheck::check(const MatchFinder::MatchResult &Result) {
const auto *If = Result.Nodes.getNodeAs<IfStmt>("if");
SourceLocation ElseLoc = If->getElseLoc();
DiagnosticBuilder Diag = diag(ElseLoc, "don't use else after return");
Diag << removeToken(ElseLoc);
// FIXME: Removing the braces isn't always safe. Do a more careful analysis.
// FIXME: Change clang-format to correctly un-indent the code.
if (const auto *CS = Result.Nodes.getNodeAs<CompoundStmt>("else"))
Diag << removeToken(CS->getLBracLoc()) << removeToken(CS->getRBracLoc());
}
} // namespace readability
} // namespace tidy
} // namespace clang
|
