diff options
Diffstat (limited to 'llvm')
-rw-r--r-- | llvm/lib/MC/MCParser/AsmParser.cpp | 6 | ||||
-rw-r--r-- | llvm/test/MC/AsmParser/macro-duplicate-params-names-err.s | 7 |
2 files changed, 13 insertions, 0 deletions
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp index 9d5eaf31408..e65ce9f0b93 100644 --- a/llvm/lib/MC/MCParser/AsmParser.cpp +++ b/llvm/lib/MC/MCParser/AsmParser.cpp @@ -3874,6 +3874,12 @@ bool AsmParser::parseDirectiveMacro(SMLoc DirectiveLoc) { if (parseIdentifier(Parameter.Name)) return TokError("expected identifier in '.macro' directive"); + // Emit an error if two (or more) named parameters share the same name + for (const MCAsmMacroParameter& CurrParam : Parameters) + if (CurrParam.Name.equals(Parameter.Name)) + return TokError("macro '" + Name + "' has multiple parameters" + " named '" + Parameter.Name + "'"); + if (Lexer.is(AsmToken::Colon)) { Lex(); // consume ':' diff --git a/llvm/test/MC/AsmParser/macro-duplicate-params-names-err.s b/llvm/test/MC/AsmParser/macro-duplicate-params-names-err.s new file mode 100644 index 00000000000..618cce02abd --- /dev/null +++ b/llvm/test/MC/AsmParser/macro-duplicate-params-names-err.s @@ -0,0 +1,7 @@ +// RUN: not llvm-mc %s 2> %t +// RUN: FileCheck < %t %s + +.macro M a a +.endm + +// CHECK: macro 'M' has multiple parameters named 'a' |