summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
Diffstat (limited to 'llvm')
-rw-r--r--llvm/lib/Transforms/Scalar/LoopUnswitch.cpp3
-rw-r--r--llvm/test/Transforms/LoopUnswitch/pr32818.ll19
2 files changed, 21 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
index 0b56b4e7ab1..2cda954a096 100644
--- a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
@@ -1275,7 +1275,8 @@ static void ReplaceUsesOfWith(Instruction *I, Value *V,
LPM->deleteSimpleAnalysisValue(I, L);
RemoveFromWorklist(I, Worklist);
I->replaceAllUsesWith(V);
- I->eraseFromParent();
+ if (!I->mayHaveSideEffects())
+ I->eraseFromParent();
++NumSimplify;
}
diff --git a/llvm/test/Transforms/LoopUnswitch/pr32818.ll b/llvm/test/Transforms/LoopUnswitch/pr32818.ll
new file mode 100644
index 00000000000..cda66c9dd36
--- /dev/null
+++ b/llvm/test/Transforms/LoopUnswitch/pr32818.ll
@@ -0,0 +1,19 @@
+; Check that the call doesn't get removed even if
+; it has no uses. It could have side-effects.
+; RUN: opt -loop-unswitch -S %s | FileCheck %s
+
+; CHECK-LABEL: @tinky
+define i32 @tinkywinky(i8 %patatino) {
+ %cmp1 = icmp slt i8 %patatino, 5
+ br label %body
+body:
+ %i = select i1 %cmp1, i8 6, i8 undef
+ br i1 true, label %body, label %end
+end:
+ %split = phi i8 [ %i, %body ]
+ %conv4 = sext i8 %split to i32
+; CHECK: tail call fastcc i32 @fn5(
+ %call = tail call fastcc i32 @fn5(i32 %conv4)
+ ret i32 0
+}
+declare fastcc i32 @fn5(i32 returned) unnamed_addr
OpenPOWER on IntegriCloud