diff options
Diffstat (limited to 'llvm/tools/llvm-cov')
-rw-r--r-- | llvm/tools/llvm-cov/CodeCoverage.cpp | 12 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/CoverageExporterJson.cpp | 19 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/CoverageViewOptions.h | 1 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageView.cpp | 5 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageView.h | 4 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp | 7 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageViewText.cpp | 4 |
7 files changed, 11 insertions, 41 deletions
diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index 15d257914a5..6bd61d3ef75 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -39,8 +39,7 @@ using namespace llvm; using namespace coverage; -void exportCoverageDataToJson(StringRef ObjectFilename, - const coverage::CoverageMapping &CoverageMapping, +void exportCoverageDataToJson(const coverage::CoverageMapping &CoverageMapping, raw_ostream &OS); namespace { @@ -570,13 +569,6 @@ int CodeCoverageTool::run(Command Cmd, int argc, const char **argv) { CompareFilenamesOnly = FilenameEquivalence; ViewOpts.Format = Format; - SmallString<128> ObjectFilePath(this->ObjectFilename); - if (std::error_code EC = sys::fs::make_absolute(ObjectFilePath)) { - error(EC.message(), this->ObjectFilename); - return 1; - } - sys::path::native(ObjectFilePath); - ViewOpts.ObjectFilename = ObjectFilePath.c_str(); switch (ViewOpts.Format) { case CoverageViewOptions::OutputFormat::Text: ViewOpts.Colors = UseColor == cl::BOU_UNSET @@ -843,7 +835,7 @@ int CodeCoverageTool::export_(int argc, const char **argv, return 1; } - exportCoverageDataToJson(ObjectFilename, *Coverage.get(), outs()); + exportCoverageDataToJson(*Coverage.get(), outs()); return 0; } diff --git a/llvm/tools/llvm-cov/CoverageExporterJson.cpp b/llvm/tools/llvm-cov/CoverageExporterJson.cpp index 1b5a1ac01c5..ef50bba2123 100644 --- a/llvm/tools/llvm-cov/CoverageExporterJson.cpp +++ b/llvm/tools/llvm-cov/CoverageExporterJson.cpp @@ -48,7 +48,7 @@ #include <stack> /// \brief The semantic version combined as a string. -#define LLVM_COVERAGE_EXPORT_JSON_STR "1.1.0" +#define LLVM_COVERAGE_EXPORT_JSON_STR "2.0.0" /// \brief Unique type identifier for JSON coverage export. #define LLVM_COVERAGE_EXPORT_JSON_TYPE_STR "llvm.coverage.json.export" @@ -57,9 +57,6 @@ using namespace llvm; using namespace coverage; class CoverageExporterJson { - /// \brief A Name of the object file coverage is for. - StringRef ObjectFilename; - /// \brief Output stream to print JSON to. raw_ostream &OS; @@ -72,9 +69,6 @@ class CoverageExporterJson { /// \brief Tracks state of the JSON output. std::stack<JsonState> State; - /// \brief Get the object filename. - StringRef getObjectFilename() const { return ObjectFilename; } - /// \brief Emit a serialized scalar. void emitSerialized(const int64_t Value) { OS << Value; } @@ -170,7 +164,6 @@ class CoverageExporterJson { // Start Export. emitDictStart(); - emitDictElement("object", getObjectFilename()); emitDictKey("files"); @@ -410,9 +403,8 @@ class CoverageExporterJson { } public: - CoverageExporterJson(StringRef ObjectFilename, - const CoverageMapping &CoverageMapping, raw_ostream &OS) - : ObjectFilename(ObjectFilename), OS(OS), Coverage(CoverageMapping) { + CoverageExporterJson(const CoverageMapping &CoverageMapping, raw_ostream &OS) + : OS(OS), Coverage(CoverageMapping) { State.push(JsonState::None); } @@ -421,10 +413,9 @@ public: }; /// \brief Export the given CoverageMapping to a JSON Format. -void exportCoverageDataToJson(StringRef ObjectFilename, - const CoverageMapping &CoverageMapping, +void exportCoverageDataToJson(const CoverageMapping &CoverageMapping, raw_ostream &OS) { - auto Exporter = CoverageExporterJson(ObjectFilename, CoverageMapping, OS); + auto Exporter = CoverageExporterJson(CoverageMapping, OS); Exporter.print(); } diff --git a/llvm/tools/llvm-cov/CoverageViewOptions.h b/llvm/tools/llvm-cov/CoverageViewOptions.h index faa46da53ed..266b380b7d3 100644 --- a/llvm/tools/llvm-cov/CoverageViewOptions.h +++ b/llvm/tools/llvm-cov/CoverageViewOptions.h @@ -36,7 +36,6 @@ struct CoverageViewOptions { std::vector<std::string> DemanglerOpts; uint32_t TabSize; std::string ProjectTitle; - std::string ObjectFilename; std::string CreatedTimeStr; /// \brief Change the output's stream color if the colors are enabled. diff --git a/llvm/tools/llvm-cov/SourceCoverageView.cpp b/llvm/tools/llvm-cov/SourceCoverageView.cpp index 8b3ffe7c63a..52b8ff1747f 100644 --- a/llvm/tools/llvm-cov/SourceCoverageView.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageView.cpp @@ -149,11 +149,6 @@ std::string SourceCoverageView::getSourceName() const { return SourceText.str(); } -std::string SourceCoverageView::getVerboseSourceName() const { - return getSourceName() + " (Binary: " + - sys::path::filename(getOptions().ObjectFilename).str() + ")"; -} - void SourceCoverageView::addExpansion( const coverage::CounterMappingRegion &Region, std::unique_ptr<SourceCoverageView> View) { diff --git a/llvm/tools/llvm-cov/SourceCoverageView.h b/llvm/tools/llvm-cov/SourceCoverageView.h index 2069fe56d8c..21672f5e738 100644 --- a/llvm/tools/llvm-cov/SourceCoverageView.h +++ b/llvm/tools/llvm-cov/SourceCoverageView.h @@ -277,10 +277,6 @@ public: /// \brief Return the source name formatted for the host OS. std::string getSourceName() const; - /// \brief Return a verbose description of the source name and the binary it - /// corresponds to. - std::string getVerboseSourceName() const; - const CoverageViewOptions &getOptions() const { return Options; } /// \brief Add an expansion subview to this view. diff --git a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp index 2707260b8ad..b43db61d89d 100644 --- a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp @@ -406,11 +406,8 @@ void SourceCoverageViewHTML::renderViewFooter(raw_ostream &OS) { } void SourceCoverageViewHTML::renderSourceName(raw_ostream &OS, bool WholeFile) { - OS << BeginSourceNameDiv; - std::string ViewInfo = escape( - WholeFile ? getVerboseSourceName() : getSourceName(), getOptions()); - OS << tag("pre", ViewInfo); - OS << EndSourceNameDiv; + OS << BeginSourceNameDiv << tag("pre", escape(getSourceName(), getOptions())) + << EndSourceNameDiv; } void SourceCoverageViewHTML::renderLinePrefix(raw_ostream &OS, unsigned) { diff --git a/llvm/tools/llvm-cov/SourceCoverageViewText.cpp b/llvm/tools/llvm-cov/SourceCoverageViewText.cpp index 68891298a07..4ad120f642e 100644 --- a/llvm/tools/llvm-cov/SourceCoverageViewText.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageViewText.cpp @@ -70,8 +70,8 @@ void SourceCoverageViewText::renderViewHeader(raw_ostream &) {} void SourceCoverageViewText::renderViewFooter(raw_ostream &) {} void SourceCoverageViewText::renderSourceName(raw_ostream &OS, bool WholeFile) { - std::string ViewInfo = WholeFile ? getVerboseSourceName() : getSourceName(); - getOptions().colored_ostream(OS, raw_ostream::CYAN) << ViewInfo << ":\n"; + getOptions().colored_ostream(OS, raw_ostream::CYAN) << getSourceName() + << ":\n"; } void SourceCoverageViewText::renderLinePrefix(raw_ostream &OS, |