diff options
Diffstat (limited to 'llvm/lib/IR/Metadata.cpp')
-rw-r--r-- | llvm/lib/IR/Metadata.cpp | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/llvm/lib/IR/Metadata.cpp b/llvm/lib/IR/Metadata.cpp index bed2b6bd422..1a651573733 100644 --- a/llvm/lib/IR/Metadata.cpp +++ b/llvm/lib/IR/Metadata.cpp @@ -515,13 +515,8 @@ void GenericMDNode::handleChangedOperand(void *Ref, Metadata *New) { Metadata *Old = getOperand(Op); setOperand(Op, New); - // Drop uniquing for self-reference cycles or if an operand drops to null. - // - // FIXME: Stop dropping uniquing when an operand drops to null. The original - // motivation was to prevent madness during teardown of LLVMContextImpl, but - // dropAllReferences() fixes that problem in a better way. (It's just here - // now for better staging of semantic changes.) - if (New == this || !New) { + // Drop uniquing for self-reference cycles. + if (New == this) { storeDistinctInContext(); setHash(0); if (!isResolved()) |