diff options
Diffstat (limited to 'lldb')
| -rw-r--r-- | lldb/include/lldb/Utility/StringExtractor.h | 17 | ||||
| -rw-r--r-- | lldb/source/Utility/StringExtractor.cpp | 28 | ||||
| -rw-r--r-- | lldb/tools/debugserver/source/StdStringExtractor.cpp | 28 | ||||
| -rw-r--r-- | lldb/tools/debugserver/source/StdStringExtractor.h | 3 |
4 files changed, 8 insertions, 68 deletions
diff --git a/lldb/include/lldb/Utility/StringExtractor.h b/lldb/include/lldb/Utility/StringExtractor.h index f20ec92199b..e3e9c7ce319 100644 --- a/lldb/include/lldb/Utility/StringExtractor.h +++ b/lldb/include/lldb/Utility/StringExtractor.h @@ -91,9 +91,6 @@ public: size_t GetHexBytesAvail(llvm::MutableArrayRef<uint8_t> dest); - uint64_t GetHexWithFixedSize(uint32_t byte_size, bool little_endian, - uint64_t fail_value); - size_t GetHexByteString(std::string &str); size_t GetHexByteStringFixedLength(std::string &str, uint32_t nibble_length); @@ -113,12 +110,14 @@ protected: m_index = UINT64_MAX; return false; } - // For StringExtractor only - std::string m_packet; // The string in which to extract data. - uint64_t m_index; // When extracting data from a packet, this index - // will march along as things get extracted. If set to - // UINT64_MAX the end of the packet data was reached - // when decoding information + + /// The string in which to extract data. + std::string m_packet; + + /// When extracting data from a packet, this index will march along as things + /// get extracted. If set to UINT64_MAX the end of the packet data was + /// reached when decoding information. + uint64_t m_index; }; #endif // utility_StringExtractor_h_ diff --git a/lldb/source/Utility/StringExtractor.cpp b/lldb/source/Utility/StringExtractor.cpp index 502f468da3c..87fe4f13e45 100644 --- a/lldb/source/Utility/StringExtractor.cpp +++ b/lldb/source/Utility/StringExtractor.cpp @@ -296,34 +296,6 @@ size_t StringExtractor::GetHexBytesAvail(llvm::MutableArrayRef<uint8_t> dest) { return bytes_extracted; } -// Consume ASCII hex nibble character pairs until we have decoded byte_size -// bytes of data. - -uint64_t StringExtractor::GetHexWithFixedSize(uint32_t byte_size, - bool little_endian, - uint64_t fail_value) { - if (byte_size <= 8 && GetBytesLeft() >= byte_size * 2) { - uint64_t result = 0; - uint32_t i; - if (little_endian) { - // Little Endian - uint32_t shift_amount; - for (i = 0, shift_amount = 0; i < byte_size && IsGood(); - ++i, shift_amount += 8) { - result |= (static_cast<uint64_t>(GetHexU8()) << shift_amount); - } - } else { - // Big Endian - for (i = 0; i < byte_size && IsGood(); ++i) { - result <<= 8; - result |= GetHexU8(); - } - } - } - m_index = UINT64_MAX; - return fail_value; -} - size_t StringExtractor::GetHexByteString(std::string &str) { str.clear(); str.reserve(GetBytesLeft() / 2); diff --git a/lldb/tools/debugserver/source/StdStringExtractor.cpp b/lldb/tools/debugserver/source/StdStringExtractor.cpp index e32689cbb5b..a4cad2d4bbf 100644 --- a/lldb/tools/debugserver/source/StdStringExtractor.cpp +++ b/lldb/tools/debugserver/source/StdStringExtractor.cpp @@ -281,34 +281,6 @@ size_t StdStringExtractor::GetHexBytesAvail(void *dst_void, size_t dst_len) { return bytes_extracted; } -// Consume ASCII hex nibble character pairs until we have decoded byte_size -// bytes of data. - -uint64_t StdStringExtractor::GetHexWithFixedSize(uint32_t byte_size, - bool little_endian, - uint64_t fail_value) { - if (byte_size <= 8 && GetBytesLeft() >= byte_size * 2) { - uint64_t result = 0; - uint32_t i; - if (little_endian) { - // Little Endian - uint32_t shift_amount; - for (i = 0, shift_amount = 0; i < byte_size && IsGood(); - ++i, shift_amount += 8) { - result |= ((uint64_t)GetHexU8() << shift_amount); - } - } else { - // Big Endian - for (i = 0; i < byte_size && IsGood(); ++i) { - result <<= 8; - result |= GetHexU8(); - } - } - } - m_index = UINT64_MAX; - return fail_value; -} - size_t StdStringExtractor::GetHexByteString(std::string &str) { str.clear(); str.reserve(GetBytesLeft() / 2); diff --git a/lldb/tools/debugserver/source/StdStringExtractor.h b/lldb/tools/debugserver/source/StdStringExtractor.h index 2cad0f14b5f..031786457e1 100644 --- a/lldb/tools/debugserver/source/StdStringExtractor.h +++ b/lldb/tools/debugserver/source/StdStringExtractor.h @@ -83,9 +83,6 @@ public: size_t GetHexBytesAvail(void *dst, size_t dst_len); - uint64_t GetHexWithFixedSize(uint32_t byte_size, bool little_endian, - uint64_t fail_value); - size_t GetHexByteString(std::string &str); size_t GetHexByteStringFixedLength(std::string &str, uint32_t nibble_length); |

