diff options
Diffstat (limited to 'lldb/unittests/ScriptInterpreter/Python')
4 files changed, 74 insertions, 17 deletions
diff --git a/lldb/unittests/ScriptInterpreter/Python/CMakeLists.txt b/lldb/unittests/ScriptInterpreter/Python/CMakeLists.txt index 5b6677549b4..16c2784b28e 100644 --- a/lldb/unittests/ScriptInterpreter/Python/CMakeLists.txt +++ b/lldb/unittests/ScriptInterpreter/Python/CMakeLists.txt @@ -1,5 +1,6 @@ add_lldb_unittest(ScriptInterpreterPythonTests PythonDataObjectsTests.cpp + PythonTestSuite.cpp ) target_link_libraries(ScriptInterpreterPythonTests lldbPluginScriptInterpreterPython ${PYTHON_LIBRARY}) diff --git a/lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp b/lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp index 86e6125c869..5c6925179c6 100644 --- a/lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp +++ b/lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp @@ -16,25 +16,17 @@ #include "Plugins/ScriptInterpreter/Python/PythonDataObjects.h" #include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h" +#include "PythonTestSuite.h" + using namespace lldb_private; -class PythonDataObjectsTest : public testing::Test +class PythonDataObjectsTest : public PythonTestSuite { public: void SetUp() override { - HostInfoBase::Initialize(); - // ScriptInterpreterPython::Initialize() depends on HostInfo being - // initializedso it can compute the python directory etc. - ScriptInterpreterPython::Initialize(); - - // Although we don't care about concurrency for the purposes of running - // this test suite, Python requires the GIL to be locked even for - // deallocating memory, which can happen when you call Py_DECREF or - // Py_INCREF. So acquire the GIL for the entire duration of this - // test suite. - m_gil_state = PyGILState_Ensure(); + PythonTestSuite::SetUp(); PythonString sys_module("sys"); m_sys_module.Reset(PyRefType::Owned, PyImport_Import(sys_module.get())); @@ -48,18 +40,14 @@ class PythonDataObjectsTest : public testing::Test m_sys_module.Reset(); m_main_module.Reset(); m_builtins_module.Reset(); - PyGILState_Release(m_gil_state); - ScriptInterpreterPython::Terminate(); + PythonTestSuite::TearDown(); } protected: PythonModule m_sys_module; PythonModule m_main_module; PythonModule m_builtins_module; - - private: - PyGILState_STATE m_gil_state; }; TEST_F(PythonDataObjectsTest, TestOwnedReferences) diff --git a/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp b/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp new file mode 100644 index 00000000000..3d1727dc1c2 --- /dev/null +++ b/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp @@ -0,0 +1,42 @@ +//===-- PythonTestSuite.cpp -------------------------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "gtest/gtest.h" + +#include "lldb/Host/HostInfo.h" +#include "Plugins/ScriptInterpreter/Python/lldb-python.h" +#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h" + +#include "PythonTestSuite.h" + +using namespace lldb_private; + +void +PythonTestSuite::SetUp() +{ + HostInfoBase::Initialize(); + // ScriptInterpreterPython::Initialize() depends on HostInfo being + // initializedso it can compute the python directory etc. + ScriptInterpreterPython::Initialize(); + + // Although we don't care about concurrency for the purposes of running + // this test suite, Python requires the GIL to be locked even for + // deallocating memory, which can happen when you call Py_DECREF or + // Py_INCREF. So acquire the GIL for the entire duration of this + // test suite. + m_gil_state = PyGILState_Ensure(); +} + +void +PythonTestSuite::TearDown() +{ + PyGILState_Release(m_gil_state); + + ScriptInterpreterPython::Terminate(); +} diff --git a/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.h b/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.h new file mode 100644 index 00000000000..461fc1d5676 --- /dev/null +++ b/lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.h @@ -0,0 +1,26 @@ +//===-- PythonTestSuite.cpp -------------------------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "gtest/gtest.h" + +using namespace lldb_private; + +class PythonTestSuite : public testing::Test +{ +public: + void + SetUp() override; + + void + TearDown() override; + +private: + PyGILState_STATE m_gil_state; +}; + |
