diff options
Diffstat (limited to 'lldb/source/Interpreter')
| -rw-r--r-- | lldb/source/Interpreter/Args.cpp | 242 | ||||
| -rw-r--r-- | lldb/source/Interpreter/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionArgParser.cpp | 253 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp | 9 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionGroupWatchpoint.cpp | 6 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionValueBoolean.cpp | 4 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionValueChar.cpp | 4 | ||||
| -rw-r--r-- | lldb/source/Interpreter/OptionValueFormat.cpp | 4 | ||||
| -rw-r--r-- | lldb/source/Interpreter/Property.cpp | 10 |
9 files changed, 278 insertions, 255 deletions
diff --git a/lldb/source/Interpreter/Args.cpp b/lldb/source/Interpreter/Args.cpp index 84852475795..99d62970d1c 100644 --- a/lldb/source/Interpreter/Args.cpp +++ b/lldb/source/Interpreter/Args.cpp @@ -12,11 +12,12 @@ // C++ Includes // Other libraries and framework includes // Project includes -#include "lldb/DataFormatters/FormatManager.h" #include "lldb/Interpreter/Args.h" -#include "lldb/Target/Target.h" +#include "lldb/Interpreter/Options.h" +#include "lldb/Utility/ConstString.h" +#include "lldb/Utility/FileSpec.h" #include "lldb/Utility/Stream.h" -#include "lldb/Utility/StreamString.h" +#include "lldb/Utility/StringList.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/StringExtras.h" @@ -401,121 +402,6 @@ void Args::Clear() { m_argv.push_back(nullptr); } -lldb::addr_t Args::StringToAddress(const ExecutionContext *exe_ctx, - llvm::StringRef s, lldb::addr_t fail_value, - Status *error_ptr) { - bool error_set = false; - if (s.empty()) { - if (error_ptr) - error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", - s.str().c_str()); - return fail_value; - } - - llvm::StringRef sref = s; - - lldb::addr_t addr = LLDB_INVALID_ADDRESS; - if (!s.getAsInteger(0, addr)) { - if (error_ptr) - error_ptr->Clear(); - return addr; - } - - // Try base 16 with no prefix... - if (!s.getAsInteger(16, addr)) { - if (error_ptr) - error_ptr->Clear(); - return addr; - } - - Target *target = nullptr; - if (!exe_ctx || !(target = exe_ctx->GetTargetPtr())) { - if (error_ptr) - error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", - s.str().c_str()); - return fail_value; - } - - lldb::ValueObjectSP valobj_sp; - EvaluateExpressionOptions options; - options.SetCoerceToId(false); - options.SetUnwindOnError(true); - options.SetKeepInMemory(false); - options.SetTryAllThreads(true); - - ExpressionResults expr_result = - target->EvaluateExpression(s, exe_ctx->GetFramePtr(), valobj_sp, options); - - bool success = false; - if (expr_result == eExpressionCompleted) { - if (valobj_sp) - valobj_sp = valobj_sp->GetQualifiedRepresentationIfAvailable( - valobj_sp->GetDynamicValueType(), true); - // Get the address to watch. - if (valobj_sp) - addr = valobj_sp->GetValueAsUnsigned(fail_value, &success); - if (success) { - if (error_ptr) - error_ptr->Clear(); - return addr; - } else { - if (error_ptr) { - error_set = true; - error_ptr->SetErrorStringWithFormat( - "address expression \"%s\" resulted in a value whose type " - "can't be converted to an address: %s", - s.str().c_str(), valobj_sp->GetTypeName().GetCString()); - } - } - - } else { - // Since the compiler can't handle things like "main + 12" we should - // try to do this for now. The compiler doesn't like adding offsets - // to function pointer types. - static RegularExpression g_symbol_plus_offset_regex( - "^(.*)([-\\+])[[:space:]]*(0x[0-9A-Fa-f]+|[0-9]+)[[:space:]]*$"); - RegularExpression::Match regex_match(3); - if (g_symbol_plus_offset_regex.Execute(sref, ®ex_match)) { - uint64_t offset = 0; - bool add = true; - std::string name; - std::string str; - if (regex_match.GetMatchAtIndex(s, 1, name)) { - if (regex_match.GetMatchAtIndex(s, 2, str)) { - add = str[0] == '+'; - - if (regex_match.GetMatchAtIndex(s, 3, str)) { - if (!llvm::StringRef(str).getAsInteger(0, offset)) { - Status error; - addr = StringToAddress(exe_ctx, name.c_str(), - LLDB_INVALID_ADDRESS, &error); - if (addr != LLDB_INVALID_ADDRESS) { - if (add) - return addr + offset; - else - return addr - offset; - } - } - } - } - } - } - - if (error_ptr) { - error_set = true; - error_ptr->SetErrorStringWithFormat( - "address expression \"%s\" evaluation failed", s.str().c_str()); - } - } - - if (error_ptr) { - if (!error_set) - error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", - s.str().c_str()); - } - return fail_value; -} - const char *Args::StripSpaces(std::string &s, bool leading, bool trailing, bool return_null_if_empty) { static const char *k_white_space = " \t\v"; @@ -539,34 +425,6 @@ const char *Args::StripSpaces(std::string &s, bool leading, bool trailing, return s.c_str(); } -bool Args::StringToBoolean(llvm::StringRef ref, bool fail_value, - bool *success_ptr) { - if (success_ptr) - *success_ptr = true; - ref = ref.trim(); - if (ref.equals_lower("false") || ref.equals_lower("off") || - ref.equals_lower("no") || ref.equals_lower("0")) { - return false; - } else if (ref.equals_lower("true") || ref.equals_lower("on") || - ref.equals_lower("yes") || ref.equals_lower("1")) { - return true; - } - if (success_ptr) - *success_ptr = false; - return fail_value; -} - -char Args::StringToChar(llvm::StringRef s, char fail_value, bool *success_ptr) { - if (success_ptr) - *success_ptr = false; - if (s.size() != 1) - return fail_value; - - if (success_ptr) - *success_ptr = true; - return s[0]; -} - bool Args::StringToVersion(llvm::StringRef string, uint32_t &major, uint32_t &minor, uint32_t &update) { major = UINT32_MAX; @@ -628,98 +486,6 @@ const char *Args::GetShellSafeArgument(const FileSpec &shell, return safe_arg.c_str(); } -int64_t Args::StringToOptionEnum(llvm::StringRef s, - OptionEnumValueElement *enum_values, - int32_t fail_value, Status &error) { - error.Clear(); - if (!enum_values) { - error.SetErrorString("invalid enumeration argument"); - return fail_value; - } - - if (s.empty()) { - error.SetErrorString("empty enumeration string"); - return fail_value; - } - - for (int i = 0; enum_values[i].string_value != nullptr; i++) { - llvm::StringRef this_enum(enum_values[i].string_value); - if (this_enum.startswith(s)) - return enum_values[i].value; - } - - StreamString strm; - strm.PutCString("invalid enumeration value, valid values are: "); - for (int i = 0; enum_values[i].string_value != nullptr; i++) { - strm.Printf("%s\"%s\"", i > 0 ? ", " : "", enum_values[i].string_value); - } - error.SetErrorString(strm.GetString()); - return fail_value; -} - -lldb::ScriptLanguage -Args::StringToScriptLanguage(llvm::StringRef s, lldb::ScriptLanguage fail_value, - bool *success_ptr) { - if (success_ptr) - *success_ptr = true; - - if (s.equals_lower("python")) - return eScriptLanguagePython; - if (s.equals_lower("default")) - return eScriptLanguageDefault; - if (s.equals_lower("none")) - return eScriptLanguageNone; - - if (success_ptr) - *success_ptr = false; - return fail_value; -} - -Status Args::StringToFormat(const char *s, lldb::Format &format, - size_t *byte_size_ptr) { - format = eFormatInvalid; - Status error; - - if (s && s[0]) { - if (byte_size_ptr) { - if (isdigit(s[0])) { - char *format_char = nullptr; - unsigned long byte_size = ::strtoul(s, &format_char, 0); - if (byte_size != ULONG_MAX) - *byte_size_ptr = byte_size; - s = format_char; - } else - *byte_size_ptr = 0; - } - - const bool partial_match_ok = true; - if (!FormatManager::GetFormatFromCString(s, partial_match_ok, format)) { - StreamString error_strm; - error_strm.Printf( - "Invalid format character or name '%s'. Valid values are:\n", s); - for (Format f = eFormatDefault; f < kNumFormats; f = Format(f + 1)) { - char format_char = FormatManager::GetFormatAsFormatChar(f); - if (format_char) - error_strm.Printf("'%c' or ", format_char); - - error_strm.Printf("\"%s\"", FormatManager::GetFormatAsCString(f)); - error_strm.EOL(); - } - - if (byte_size_ptr) - error_strm.PutCString( - "An optional byte size can precede the format character.\n"); - error.SetErrorString(error_strm.GetString()); - } - - if (error.Fail()) - return error; - } else { - error.SetErrorStringWithFormat("%s option string", s ? "empty" : "invalid"); - } - return error; -} - lldb::Encoding Args::StringToEncoding(llvm::StringRef s, lldb::Encoding fail_value) { return llvm::StringSwitch<lldb::Encoding>(s) diff --git a/lldb/source/Interpreter/CMakeLists.txt b/lldb/source/Interpreter/CMakeLists.txt index 0ab25f17144..4ae5dc5896d 100644 --- a/lldb/source/Interpreter/CMakeLists.txt +++ b/lldb/source/Interpreter/CMakeLists.txt @@ -8,6 +8,7 @@ add_lldb_library(lldbInterpreter CommandObjectScript.cpp CommandOptionValidators.cpp CommandReturnObject.cpp + OptionArgParser.cpp OptionGroupArchitecture.cpp OptionGroupBoolean.cpp OptionGroupFile.cpp diff --git a/lldb/source/Interpreter/OptionArgParser.cpp b/lldb/source/Interpreter/OptionArgParser.cpp new file mode 100644 index 00000000000..d4830df4262 --- /dev/null +++ b/lldb/source/Interpreter/OptionArgParser.cpp @@ -0,0 +1,253 @@ +//===-- OptionArgParser.cpp -------------------------------------*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "lldb/Interpreter/OptionArgParser.h" +#include "lldb/DataFormatters/FormatManager.h" +#include "lldb/Target/Target.h" +#include "lldb/Utility/Status.h" +#include "lldb/Utility/StreamString.h" + +using namespace lldb_private; +using namespace lldb; + +bool OptionArgParser::ToBoolean(llvm::StringRef ref, bool fail_value, + bool *success_ptr) { + if (success_ptr) + *success_ptr = true; + ref = ref.trim(); + if (ref.equals_lower("false") || ref.equals_lower("off") || + ref.equals_lower("no") || ref.equals_lower("0")) { + return false; + } else if (ref.equals_lower("true") || ref.equals_lower("on") || + ref.equals_lower("yes") || ref.equals_lower("1")) { + return true; + } + if (success_ptr) + *success_ptr = false; + return fail_value; +} + +char OptionArgParser::ToChar(llvm::StringRef s, char fail_value, + bool *success_ptr) { + if (success_ptr) + *success_ptr = false; + if (s.size() != 1) + return fail_value; + + if (success_ptr) + *success_ptr = true; + return s[0]; +} + +int64_t OptionArgParser::ToOptionEnum(llvm::StringRef s, + OptionEnumValueElement *enum_values, + int32_t fail_value, Status &error) { + error.Clear(); + if (!enum_values) { + error.SetErrorString("invalid enumeration argument"); + return fail_value; + } + + if (s.empty()) { + error.SetErrorString("empty enumeration string"); + return fail_value; + } + + for (int i = 0; enum_values[i].string_value != nullptr; i++) { + llvm::StringRef this_enum(enum_values[i].string_value); + if (this_enum.startswith(s)) + return enum_values[i].value; + } + + StreamString strm; + strm.PutCString("invalid enumeration value, valid values are: "); + for (int i = 0; enum_values[i].string_value != nullptr; i++) { + strm.Printf("%s\"%s\"", i > 0 ? ", " : "", enum_values[i].string_value); + } + error.SetErrorString(strm.GetString()); + return fail_value; +} + +Status OptionArgParser::ToFormat(const char *s, lldb::Format &format, + size_t *byte_size_ptr) { + format = eFormatInvalid; + Status error; + + if (s && s[0]) { + if (byte_size_ptr) { + if (isdigit(s[0])) { + char *format_char = nullptr; + unsigned long byte_size = ::strtoul(s, &format_char, 0); + if (byte_size != ULONG_MAX) + *byte_size_ptr = byte_size; + s = format_char; + } else + *byte_size_ptr = 0; + } + + const bool partial_match_ok = true; + if (!FormatManager::GetFormatFromCString(s, partial_match_ok, format)) { + StreamString error_strm; + error_strm.Printf( + "Invalid format character or name '%s'. Valid values are:\n", s); + for (Format f = eFormatDefault; f < kNumFormats; f = Format(f + 1)) { + char format_char = FormatManager::GetFormatAsFormatChar(f); + if (format_char) + error_strm.Printf("'%c' or ", format_char); + + error_strm.Printf("\"%s\"", FormatManager::GetFormatAsCString(f)); + error_strm.EOL(); + } + + if (byte_size_ptr) + error_strm.PutCString( + "An optional byte size can precede the format character.\n"); + error.SetErrorString(error_strm.GetString()); + } + + if (error.Fail()) + return error; + } else { + error.SetErrorStringWithFormat("%s option string", s ? "empty" : "invalid"); + } + return error; +} + +lldb::ScriptLanguage OptionArgParser::ToScriptLanguage( + llvm::StringRef s, lldb::ScriptLanguage fail_value, bool *success_ptr) { + if (success_ptr) + *success_ptr = true; + + if (s.equals_lower("python")) + return eScriptLanguagePython; + if (s.equals_lower("default")) + return eScriptLanguageDefault; + if (s.equals_lower("none")) + return eScriptLanguageNone; + + if (success_ptr) + *success_ptr = false; + return fail_value; +} + +lldb::addr_t OptionArgParser::ToAddress(const ExecutionContext *exe_ctx, + llvm::StringRef s, + lldb::addr_t fail_value, + Status *error_ptr) { + bool error_set = false; + if (s.empty()) { + if (error_ptr) + error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", + s.str().c_str()); + return fail_value; + } + + llvm::StringRef sref = s; + + lldb::addr_t addr = LLDB_INVALID_ADDRESS; + if (!s.getAsInteger(0, addr)) { + if (error_ptr) + error_ptr->Clear(); + return addr; + } + + // Try base 16 with no prefix... + if (!s.getAsInteger(16, addr)) { + if (error_ptr) + error_ptr->Clear(); + return addr; + } + + Target *target = nullptr; + if (!exe_ctx || !(target = exe_ctx->GetTargetPtr())) { + if (error_ptr) + error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", + s.str().c_str()); + return fail_value; + } + + lldb::ValueObjectSP valobj_sp; + EvaluateExpressionOptions options; + options.SetCoerceToId(false); + options.SetUnwindOnError(true); + options.SetKeepInMemory(false); + options.SetTryAllThreads(true); + + ExpressionResults expr_result = + target->EvaluateExpression(s, exe_ctx->GetFramePtr(), valobj_sp, options); + + bool success = false; + if (expr_result == eExpressionCompleted) { + if (valobj_sp) + valobj_sp = valobj_sp->GetQualifiedRepresentationIfAvailable( + valobj_sp->GetDynamicValueType(), true); + // Get the address to watch. + if (valobj_sp) + addr = valobj_sp->GetValueAsUnsigned(fail_value, &success); + if (success) { + if (error_ptr) + error_ptr->Clear(); + return addr; + } else { + if (error_ptr) { + error_set = true; + error_ptr->SetErrorStringWithFormat( + "address expression \"%s\" resulted in a value whose type " + "can't be converted to an address: %s", + s.str().c_str(), valobj_sp->GetTypeName().GetCString()); + } + } + + } else { + // Since the compiler can't handle things like "main + 12" we should + // try to do this for now. The compiler doesn't like adding offsets + // to function pointer types. + static RegularExpression g_symbol_plus_offset_regex( + "^(.*)([-\\+])[[:space:]]*(0x[0-9A-Fa-f]+|[0-9]+)[[:space:]]*$"); + RegularExpression::Match regex_match(3); + if (g_symbol_plus_offset_regex.Execute(sref, ®ex_match)) { + uint64_t offset = 0; + bool add = true; + std::string name; + std::string str; + if (regex_match.GetMatchAtIndex(s, 1, name)) { + if (regex_match.GetMatchAtIndex(s, 2, str)) { + add = str[0] == '+'; + + if (regex_match.GetMatchAtIndex(s, 3, str)) { + if (!llvm::StringRef(str).getAsInteger(0, offset)) { + Status error; + addr = ToAddress(exe_ctx, name.c_str(), LLDB_INVALID_ADDRESS, + &error); + if (addr != LLDB_INVALID_ADDRESS) { + if (add) + return addr + offset; + else + return addr - offset; + } + } + } + } + } + } + + if (error_ptr) { + error_set = true; + error_ptr->SetErrorStringWithFormat( + "address expression \"%s\" evaluation failed", s.str().c_str()); + } + } + + if (error_ptr) { + if (!error_set) + error_ptr->SetErrorStringWithFormat("invalid address expression \"%s\"", + s.str().c_str()); + } + return fail_value; +} diff --git a/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp b/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp index ce27d948c93..54b45c29c70 100644 --- a/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp +++ b/lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp @@ -16,6 +16,7 @@ #include "lldb/DataFormatters/ValueObjectPrinter.h" #include "lldb/Host/OptionParser.h" #include "lldb/Interpreter/CommandInterpreter.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/Target/Target.h" #include "llvm/ADT/ArrayRef.h" @@ -85,8 +86,8 @@ Status OptionGroupValueObjectDisplay::SetOptionValue( switch (short_option) { case 'd': { int32_t result; - result = - Args::StringToOptionEnum(option_arg, g_dynamic_value_types, 2, error); + result = OptionArgParser::ToOptionEnum(option_arg, g_dynamic_value_types, 2, + error); if (error.Success()) use_dynamic = (lldb::DynamicValueType)result; } break; @@ -144,14 +145,14 @@ Status OptionGroupValueObjectDisplay::SetOptionValue( break; case 'S': - use_synth = Args::StringToBoolean(option_arg, true, &success); + use_synth = OptionArgParser::ToBoolean(option_arg, true, &success); if (!success) error.SetErrorStringWithFormat("invalid synthetic-type '%s'", option_arg.str().c_str()); break; case 'V': - run_validator = Args::StringToBoolean(option_arg, true, &success); + run_validator = OptionArgParser::ToBoolean(option_arg, true, &success); if (!success) error.SetErrorStringWithFormat("invalid validate '%s'", option_arg.str().c_str()); diff --git a/lldb/source/Interpreter/OptionGroupWatchpoint.cpp b/lldb/source/Interpreter/OptionGroupWatchpoint.cpp index dd4b8c86c91..0431fefaa7f 100644 --- a/lldb/source/Interpreter/OptionGroupWatchpoint.cpp +++ b/lldb/source/Interpreter/OptionGroupWatchpoint.cpp @@ -14,7 +14,7 @@ // Other libraries and framework includes // Project includes #include "lldb/Host/OptionParser.h" -#include "lldb/Interpreter/Args.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/lldb-enumerations.h" using namespace lldb; @@ -65,7 +65,7 @@ OptionGroupWatchpoint::SetOptionValue(uint32_t option_idx, switch (short_option) { case 'w': { WatchType tmp_watch_type; - tmp_watch_type = (WatchType)Args::StringToOptionEnum( + tmp_watch_type = (WatchType)OptionArgParser::ToOptionEnum( option_arg, g_option_table[option_idx].enum_values, 0, error); if (error.Success()) { watch_type = tmp_watch_type; @@ -74,7 +74,7 @@ OptionGroupWatchpoint::SetOptionValue(uint32_t option_idx, break; } case 's': - watch_size = (uint32_t)Args::StringToOptionEnum( + watch_size = (uint32_t)OptionArgParser::ToOptionEnum( option_arg, g_option_table[option_idx].enum_values, 0, error); break; diff --git a/lldb/source/Interpreter/OptionValueBoolean.cpp b/lldb/source/Interpreter/OptionValueBoolean.cpp index 2cb84cd6abb..43c82338892 100644 --- a/lldb/source/Interpreter/OptionValueBoolean.cpp +++ b/lldb/source/Interpreter/OptionValueBoolean.cpp @@ -14,7 +14,7 @@ // Other libraries and framework includes // Project includes #include "lldb/Host/PosixApi.h" -#include "lldb/Interpreter/Args.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/Utility/Stream.h" #include "lldb/Utility/StringList.h" #include "llvm/ADT/STLExtras.h" @@ -47,7 +47,7 @@ Status OptionValueBoolean::SetValueFromString(llvm::StringRef value_str, case eVarSetOperationReplace: case eVarSetOperationAssign: { bool success = false; - bool value = Args::StringToBoolean(value_str, false, &success); + bool value = OptionArgParser::ToBoolean(value_str, false, &success); if (success) { m_value_was_set = true; m_current_value = value; diff --git a/lldb/source/Interpreter/OptionValueChar.cpp b/lldb/source/Interpreter/OptionValueChar.cpp index 27684a27264..21fe8801472 100644 --- a/lldb/source/Interpreter/OptionValueChar.cpp +++ b/lldb/source/Interpreter/OptionValueChar.cpp @@ -13,7 +13,7 @@ // C++ Includes // Other libraries and framework includes // Project includes -#include "lldb/Interpreter/Args.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/Utility/Stream.h" #include "lldb/Utility/StringList.h" #include "llvm/ADT/STLExtras.h" @@ -47,7 +47,7 @@ Status OptionValueChar::SetValueFromString(llvm::StringRef value, case eVarSetOperationReplace: case eVarSetOperationAssign: { bool success = false; - char char_value = Args::StringToChar(value, '\0', &success); + char char_value = OptionArgParser::ToChar(value, '\0', &success); if (success) { m_current_value = char_value; m_value_was_set = true; diff --git a/lldb/source/Interpreter/OptionValueFormat.cpp b/lldb/source/Interpreter/OptionValueFormat.cpp index 24dd8fd5f71..1837804a462 100644 --- a/lldb/source/Interpreter/OptionValueFormat.cpp +++ b/lldb/source/Interpreter/OptionValueFormat.cpp @@ -14,7 +14,7 @@ // Other libraries and framework includes // Project includes #include "lldb/DataFormatters/FormatManager.h" -#include "lldb/Interpreter/Args.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/Utility/Stream.h" using namespace lldb; @@ -43,7 +43,7 @@ Status OptionValueFormat::SetValueFromString(llvm::StringRef value, case eVarSetOperationReplace: case eVarSetOperationAssign: { Format new_format; - error = Args::StringToFormat(value.str().c_str(), new_format, nullptr); + error = OptionArgParser::ToFormat(value.str().c_str(), new_format, nullptr); if (error.Success()) { m_value_was_set = true; m_current_value = new_format; diff --git a/lldb/source/Interpreter/Property.cpp b/lldb/source/Interpreter/Property.cpp index 5bac5ea0002..7e55da2f396 100644 --- a/lldb/source/Interpreter/Property.cpp +++ b/lldb/source/Interpreter/Property.cpp @@ -16,6 +16,7 @@ #include "lldb/Core/UserSettingsController.h" #include "lldb/Host/StringConvert.h" #include "lldb/Interpreter/CommandInterpreter.h" +#include "lldb/Interpreter/OptionArgParser.h" #include "lldb/Interpreter/OptionValues.h" #include "lldb/Target/Language.h" @@ -53,7 +54,7 @@ Property::Property(const PropertyDefinition &definition) // "definition.default_cstr_value" as a string value that represents the // default value. if (definition.default_cstr_value) - m_value_sp.reset(new OptionValueBoolean(Args::StringToBoolean( + m_value_sp.reset(new OptionValueBoolean(OptionArgParser::ToBoolean( llvm::StringRef(definition.default_cstr_value), false, nullptr))); else m_value_sp.reset( @@ -62,7 +63,8 @@ Property::Property(const PropertyDefinition &definition) case OptionValue::eTypeChar: { llvm::StringRef s(definition.default_cstr_value ? definition.default_cstr_value : ""); - m_value_sp = std::make_shared<OptionValueChar>(Args::StringToChar(s, '\0', nullptr)); + m_value_sp = std::make_shared<OptionValueChar>( + OptionArgParser::ToChar(s, '\0', nullptr)); break; } case OptionValue::eTypeDictionary: @@ -123,8 +125,8 @@ Property::Property(const PropertyDefinition &definition) { Format new_format = eFormatInvalid; if (definition.default_cstr_value) - Args::StringToFormat(definition.default_cstr_value, new_format, - nullptr); + OptionArgParser::ToFormat(definition.default_cstr_value, new_format, + nullptr); else new_format = (Format)definition.default_uint_value; m_value_sp.reset(new OptionValueFormat(new_format)); |

