diff options
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/AST/StmtPrinter.cpp | 6 | ||||
| -rw-r--r-- | clang/test/Misc/ast-print-char-literal.cpp | 3 |
2 files changed, 9 insertions, 0 deletions
diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp index a45b9a27270..3ee63e020ae 100644 --- a/clang/lib/AST/StmtPrinter.cpp +++ b/clang/lib/AST/StmtPrinter.cpp @@ -1250,6 +1250,12 @@ void StmtPrinter::VisitCharacterLiteral(CharacterLiteral *Node) { OS << "'\\v'"; break; default: + // A character literal might be sign-extended, which + // would result in an invalid \U escape sequence. + // FIXME: multicharacter literals such as '\xFF\xFF\xFF\xFF' + // are not correctly handled. + if ((value & ~0xFFu) == ~0xFFu && Node->getKind() == CharacterLiteral::Ascii) + value &= 0xFFu; if (value < 256 && isPrintable((unsigned char)value)) OS << "'" << (char)value << "'"; else if (value < 256) diff --git a/clang/test/Misc/ast-print-char-literal.cpp b/clang/test/Misc/ast-print-char-literal.cpp index bb5daa2444d..614b3ca9d73 100644 --- a/clang/test/Misc/ast-print-char-literal.cpp +++ b/clang/test/Misc/ast-print-char-literal.cpp @@ -13,6 +13,8 @@ void i() { h<u8'2'>(); } +char j = '\xFF'; + // CHECK: char c = u8'1'; // CHECK-NEXT: char d = '1'; // CHECK-NEXT: char e = U'1'; @@ -22,3 +24,4 @@ void i() { // CHECK: template <char c = u8'1'> // CHECK: h<u8'2'>(); +// CHECK: char j = '\xff'; |
