diff options
Diffstat (limited to 'clang')
| -rw-r--r-- | clang/lib/CodeGen/CGExprAgg.cpp | 8 | ||||
| -rw-r--r-- | clang/lib/CodeGen/CGExprConstant.cpp | 6 | ||||
| -rw-r--r-- | clang/test/CodeGenCXX/member-function-pointers.cpp | 20 | 
3 files changed, 28 insertions, 6 deletions
diff --git a/clang/lib/CodeGen/CGExprAgg.cpp b/clang/lib/CodeGen/CGExprAgg.cpp index bdeecb85be1..b6340dcbb92 100644 --- a/clang/lib/CodeGen/CGExprAgg.cpp +++ b/clang/lib/CodeGen/CGExprAgg.cpp @@ -333,8 +333,12 @@ void AggExprEmitter::VisitUnaryAddrOf(const UnaryOperator *E) {      //   (in bytes) of the function, represented as a ptrdiff_t.       FuncPtr = llvm::ConstantInt::get(PtrDiffTy, (Index * 8) + 1);    } else { -    FuncPtr = llvm::ConstantExpr::getPtrToInt(CGF.CGM.GetAddrOfFunction(MD),  -                                              PtrDiffTy); +    const FunctionProtoType *FPT = MD->getType()->getAs<FunctionProtoType>(); +    const llvm::Type *Ty = +      CGF.CGM.getTypes().GetFunctionType(CGF.CGM.getTypes().getFunctionInfo(MD), +                                         FPT->isVariadic()); +    llvm::Constant *Fn = CGF.CGM.GetAddrOfFunction(MD, Ty); +    FuncPtr = llvm::ConstantExpr::getPtrToInt(Fn, PtrDiffTy);    }    Builder.CreateStore(FuncPtr, DstPtr, VolatileDest); diff --git a/clang/lib/CodeGen/CGExprConstant.cpp b/clang/lib/CodeGen/CGExprConstant.cpp index dca09feebc9..5800ce770c3 100644 --- a/clang/lib/CodeGen/CGExprConstant.cpp +++ b/clang/lib/CodeGen/CGExprConstant.cpp @@ -425,8 +425,12 @@ public:        //   (in bytes) of the function, represented as a ptrdiff_t.         Values[0] = llvm::ConstantInt::get(PtrDiffTy, (Index * 8) + 1);      } else { -      llvm::Constant *FuncPtr = CGM.GetAddrOfFunction(MD); +      const FunctionProtoType *FPT = MD->getType()->getAs<FunctionProtoType>(); +      const llvm::Type *Ty = +        CGM.getTypes().GetFunctionType(CGM.getTypes().getFunctionInfo(MD), +                                       FPT->isVariadic()); +      llvm::Constant *FuncPtr = CGM.GetAddrOfFunction(MD, Ty);        Values[0] = llvm::ConstantExpr::getPtrToInt(FuncPtr, PtrDiffTy);      }  diff --git a/clang/test/CodeGenCXX/member-function-pointers.cpp b/clang/test/CodeGenCXX/member-function-pointers.cpp index b69aea7fb6e..f7c445b1cb1 100644 --- a/clang/test/CodeGenCXX/member-function-pointers.cpp +++ b/clang/test/CodeGenCXX/member-function-pointers.cpp @@ -9,7 +9,7 @@ void (A::*volatile vpa)();  void (B::*pb)();  void (C::*pc)(); -// CHECK: @pa2 = global %0 { i64 ptrtoint (void ()* @_ZN1A1fEv to i64), i64 0 }, align 8 +// CHECK: @pa2 = global %0 { i64 ptrtoint (void (%struct.A*)* @_ZN1A1fEv to i64), i64 0 }, align 8  void (A::*pa2)() = &A::f;  // CHECK: @pa3 = global %0 { i64 1, i64 0 }, align 8 @@ -18,7 +18,7 @@ void (A::*pa3)() = &A::vf1;  // CHECK: @pa4 = global %0 { i64 9, i64 0 }, align 8  void (A::*pa4)() = &A::vf2; -// CHECK: @pc2 = global %0 { i64 ptrtoint (void ()* @_ZN1A1fEv to i64), i64 16 }, align 8 +// CHECK: @pc2 = global %0 { i64 ptrtoint (void (%struct.A*)* @_ZN1A1fEv to i64), i64 16 }, align 8  void (C::*pc2)() = &C::f;  // CHECK: @pc3 = global %0 { i64 1, i64 0 }, align 8 @@ -46,7 +46,7 @@ void f() {  void f2() {    // CHECK: [[pa2ptr:%[a-zA-Z0-9\.]+]] = getelementptr inbounds %0* %pa2, i32 0, i32 0  -  // CHECK: store i64 ptrtoint (void ()* @_ZN1A1fEv to i64), i64* [[pa2ptr]] +  // CHECK: store i64 ptrtoint (void (%struct.A*)* @_ZN1A1fEv to i64), i64* [[pa2ptr]]    // CHECK: [[pa2adj:%[a-zA-Z0-9\.]+]] = getelementptr inbounds %0* %pa2, i32 0, i32 1    // CHECK: store i64 0, i64* [[pa2adj]]    void (A::*pa2)() = &A::f; @@ -159,3 +159,17 @@ namespace MemberPointerImpCast {      (obj->*method)();    }  } + +// PR6258 +namespace PR6258 { + +  struct A { +    void f(bool); +  }; + +  void (A::*pf)(bool) = &A::f; + +  void f() { +    void (A::*pf)(bool) = &A::f; +  } +}  | 

