diff options
Diffstat (limited to 'clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp')
-rw-r--r-- | clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp | 33 |
1 files changed, 16 insertions, 17 deletions
diff --git a/clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp b/clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp index e170801a034..23a8fd3a476 100644 --- a/clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp +++ b/clang-tools-extra/cpp11-migrate/UseNullptr/NullptrActions.cpp @@ -47,7 +47,7 @@ bool isReplaceableRange(SourceLocation StartLoc, SourceLocation EndLoc, /// \brief Replaces the provided range with the text "nullptr", but only if /// the start and end location are both in main file. /// Returns true if and only if a replacement was made. -void ReplaceWithNullptr(tooling::Replacements &Replace, SourceManager &SM, +void ReplaceWithNullptr(Transform &Owner, SourceManager &SM, SourceLocation StartLoc, SourceLocation EndLoc) { CharSourceRange Range(SourceRange(StartLoc, EndLoc), true); // Add a space if nullptr follows an alphanumeric character. This happens @@ -55,9 +55,11 @@ void ReplaceWithNullptr(tooling::Replacements &Replace, SourceManager &SM, // parentheses and right beside a return statement. SourceLocation PreviousLocation = StartLoc.getLocWithOffset(-1); if (isAlphanumeric(*FullSourceLoc(PreviousLocation, SM).getCharacterData())) - Replace.insert(tooling::Replacement(SM, Range, " nullptr")); + Owner.addReplacementForCurrentTU( + tooling::Replacement(SM, Range, " nullptr")); else - Replace.insert(tooling::Replacement(SM, Range, "nullptr")); + Owner.addReplacementForCurrentTU( + tooling::Replacement(SM, Range, "nullptr")); } /// \brief Returns the name of the outermost macro. @@ -153,10 +155,9 @@ private: /// ambiguities. class CastSequenceVisitor : public RecursiveASTVisitor<CastSequenceVisitor> { public: - CastSequenceVisitor(tooling::Replacements &R, ASTContext &Context, - const UserMacroNames &UserNullMacros, - unsigned &AcceptedChanges, const Transform &Owner) - : Replace(R), SM(Context.getSourceManager()), Context(Context), + CastSequenceVisitor(ASTContext &Context, const UserMacroNames &UserNullMacros, + unsigned &AcceptedChanges, Transform &Owner) + : SM(Context.getSourceManager()), Context(Context), UserNullMacros(UserNullMacros), AcceptedChanges(AcceptedChanges), Owner(Owner), FirstSubExpr(0), PruneSubtree(false) {} @@ -196,7 +197,7 @@ public: FileLocEnd = SM.getFileLoc(EndLoc); if (isReplaceableRange(FileLocStart, FileLocEnd, SM, Owner) && allArgUsesValid(C)) { - ReplaceWithNullptr(Replace, SM, FileLocStart, FileLocEnd); + ReplaceWithNullptr(Owner, SM, FileLocStart, FileLocEnd); ++AcceptedChanges; } return skipSubTree(); @@ -220,7 +221,7 @@ public: if (!isReplaceableRange(StartLoc, EndLoc, SM, Owner)) { return skipSubTree(); } - ReplaceWithNullptr(Replace, SM, StartLoc, EndLoc); + ReplaceWithNullptr(Owner, SM, StartLoc, EndLoc); ++AcceptedChanges; return skipSubTree(); @@ -417,21 +418,19 @@ private: } private: - tooling::Replacements &Replace; SourceManager &SM; ASTContext &Context; const UserMacroNames &UserNullMacros; unsigned &AcceptedChanges; - const Transform &Owner; + Transform &Owner; Expr *FirstSubExpr; bool PruneSubtree; }; } // namespace -NullptrFixer::NullptrFixer(clang::tooling::Replacements &Replace, - unsigned &AcceptedChanges, RiskLevel, - const Transform &Owner) - : Replace(Replace), AcceptedChanges(AcceptedChanges), Owner(Owner) { +NullptrFixer::NullptrFixer(unsigned &AcceptedChanges, RiskLevel, + Transform &Owner) + : AcceptedChanges(AcceptedChanges), Owner(Owner) { if (!UserNullMacroNames.empty()) { llvm::StringRef S = UserNullMacroNames; S.split(UserNullMacros, ","); @@ -445,7 +444,7 @@ void NullptrFixer::run(const ast_matchers::MatchFinder::MatchResult &Result) { // Given an implicit null-ptr cast or an explicit cast with an implicit // null-to-pointer cast within use CastSequenceVisitor to identify sequences // of explicit casts that can be converted into 'nullptr'. - CastSequenceVisitor Visitor(Replace, *Result.Context, UserNullMacros, - AcceptedChanges, Owner); + CastSequenceVisitor Visitor(*Result.Context, UserNullMacros, AcceptedChanges, + Owner); Visitor.TraverseStmt(const_cast<CastExpr *>(NullCast)); } |