diff options
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp index b5ac6cea492..1ee97576c7a 100644 --- a/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp @@ -118,11 +118,10 @@ void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) { } diag(FD->getLocation(), - "function '%0' defined in a header file; " + "function %0 defined in a header file; " "function definitions in header files can lead to ODR violations") - << FD->getNameInfo().getName().getAsString() - << FixItHint::CreateInsertion(FD->getSourceRange().getBegin(), - "inline "); + << FD << FixItHint::CreateInsertion(FD->getSourceRange().getBegin(), + "inline "); } else if (const auto *VD = dyn_cast<VarDecl>(ND)) { // Static data members of a class template are allowed. if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember()) @@ -134,9 +133,9 @@ void DefinitionsInHeadersCheck::check(const MatchFinder::MatchResult &Result) { return; diag(VD->getLocation(), - "variable '%0' defined in a header file; " + "variable %0 defined in a header file; " "variable definitions in header files can lead to ODR violations") - << VD->getName(); + << VD; } } |