diff options
Diffstat (limited to 'clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp')
-rw-r--r-- | clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp b/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp index a1ecfbd9d3c..267848a9bdd 100644 --- a/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/AssignOperatorSignatureCheck.cpp @@ -51,11 +51,11 @@ void AssignOperatorSignatureCheck::registerMatchers( .bind("ArgumentType"), this); - Finder->addMatcher(cxxMethodDecl(IsSelfAssign, isConst()).bind("Const"), - this); + Finder->addMatcher( + cxxMethodDecl(IsSelfAssign, anyOf(isConst(), isVirtual())).bind("cv"), + this); } - void AssignOperatorSignatureCheck::check( const MatchFinder::MatchResult &Result) { const auto* Method = Result.Nodes.getNodeAs<CXXMethodDecl>("method"); @@ -64,12 +64,13 @@ void AssignOperatorSignatureCheck::check( static const char *Messages[][2] = { {"ReturnType", "operator=() should return '%0&'"}, {"ArgumentType", "operator=() should take '%0 const&', '%0&&' or '%0'"}, - {"Const", "operator=() should not be marked 'const'"}, + {"cv", "operator=() should not be marked '%1'"} }; - for (const auto& Message : Messages) { + for (const auto &Message : Messages) { if (Result.Nodes.getNodeAs<Decl>(Message[0])) - diag(Method->getLocStart(), Message[1]) << Name; + diag(Method->getLocStart(), Message[1]) + << Name << (Method->isConst() ? "const" : "virtual"); } } |