diff options
-rw-r--r-- | clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp | 9 | ||||
-rw-r--r-- | clang/test/Analysis/array-struct-region.cpp | 6 | ||||
-rw-r--r-- | clang/test/Analysis/ctor-inlining.mm | 14 |
3 files changed, 7 insertions, 22 deletions
diff --git a/clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp b/clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp index 2e460b79e7d..eb5395e93c7 100644 --- a/clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp +++ b/clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp @@ -160,14 +160,7 @@ void ExprEngine::processCallExit(ExplodedNode *CEBNode) { svalBuilder.getCXXThis(CCE->getConstructor()->getParent(), calleeCtx); SVal ThisV = state->getSVal(This); - // If the constructed object is a prvalue, get its bindings. - // Note that we have to be careful here because constructors embedded - // in DeclStmts are not marked as lvalues. - if (!CCE->isGLValue()) - if (const MemRegion *MR = ThisV.getAsRegion()) - if (isa<CXXTempObjectRegion>(MR)) - ThisV = state->getSVal(cast<Loc>(ThisV)); - + // Always bind the region to the CXXConstructExpr. state = state->BindExpr(CCE, callerCtx, ThisV); } } diff --git a/clang/test/Analysis/array-struct-region.cpp b/clang/test/Analysis/array-struct-region.cpp index e7fbe4d9870..22fbf2ff33b 100644 --- a/clang/test/Analysis/array-struct-region.cpp +++ b/clang/test/Analysis/array-struct-region.cpp @@ -61,6 +61,12 @@ int getAssignedField(struct S s) { void testArgument() { clang_analyzer_eval(getConstrainedField(getS()) == 42); // expected-warning{{TRUE}} +#if __cplusplus + // FIXME: Passing the struct by value seems to be confusing C++. + // Possibly related to <rdar://problem/12137950>. + // expected-warning@-4{{UNKNOWN}} +#endif + clang_analyzer_eval(getAssignedField(getS()) == 42); // expected-warning{{TRUE}} } diff --git a/clang/test/Analysis/ctor-inlining.mm b/clang/test/Analysis/ctor-inlining.mm index ac963e5d9b0..918de0a4563 100644 --- a/clang/test/Analysis/ctor-inlining.mm +++ b/clang/test/Analysis/ctor-inlining.mm @@ -103,17 +103,3 @@ namespace TemporaryConstructor { return; } } - - -namespace ConstructorUsedAsRValue { - using TemporaryConstructor::BoolWrapper; - - bool extractValue(BoolWrapper b) { - return b.value; - } - - void test() { - bool result = extractValue(BoolWrapper()); - clang_analyzer_eval(result); // expected-warning{{TRUE}} - } -} |