diff options
| -rw-r--r-- | clang/lib/Analysis/GRExprEngine.cpp | 11 | ||||
| -rw-r--r-- | clang/lib/Analysis/RegionStore.cpp | 10 | ||||
| -rw-r--r-- | clang/test/Analysis/misc-ps.m | 10 |
3 files changed, 28 insertions, 3 deletions
diff --git a/clang/lib/Analysis/GRExprEngine.cpp b/clang/lib/Analysis/GRExprEngine.cpp index 60bef6eb718..d34e8a3ed3a 100644 --- a/clang/lib/Analysis/GRExprEngine.cpp +++ b/clang/lib/Analysis/GRExprEngine.cpp @@ -850,7 +850,16 @@ void GRExprEngine::VisitArraySubscriptExpr(ArraySubscriptExpr* A, NodeTy* Pred, Expr* Base = A->getBase()->IgnoreParens(); Expr* Idx = A->getIdx()->IgnoreParens(); NodeSet Tmp; - Visit(Base, Pred, Tmp); // Get Base's rvalue, which should be an LocVal. + + if (Base->getType()->isVectorType()) { + // For vector types get its lvalue. + // FIXME: This may not be correct. Is the rvalue of a vector its location? + // In fact, I think this is just a hack. We need to get the right + // semantics. + VisitLValue(Base, Pred, Tmp); + } + else + Visit(Base, Pred, Tmp); // Get Base's rvalue, which should be an LocVal. for (NodeSet::iterator I1=Tmp.begin(), E1=Tmp.end(); I1!=E1; ++I1) { NodeSet Tmp2; diff --git a/clang/lib/Analysis/RegionStore.cpp b/clang/lib/Analysis/RegionStore.cpp index e2a1d361822..c61094c20cd 100644 --- a/clang/lib/Analysis/RegionStore.cpp +++ b/clang/lib/Analysis/RegionStore.cpp @@ -591,9 +591,14 @@ SVal RegionStoreManager::Retrieve(const GRState* St, Loc L, QualType T) { // // Such funny addressing will occur due to layering of regions. - if (const TypedRegion* TR = dyn_cast<TypedRegion>(R)) - if (TR->getRValueType(getContext())->isStructureType()) + if (const TypedRegion* TR = dyn_cast<TypedRegion>(R)) { + QualType T =TR->getRValueType(getContext()); + if (T->isStructureType()) return RetrieveStruct(St, TR); + // FIXME: handle Vector types. + if (T->isVectorType()) + return UnknownVal(); + } RegionBindingsTy B = GetRegionBindings(St->getStore()); RegionBindingsTy::data_type* V = B.lookup(R); @@ -636,6 +641,7 @@ SVal RegionStoreManager::Retrieve(const GRState* St, Loc L, QualType T) { return loc::MemRegionVal(getSelfRegion(0)); } + if (MRMgr.onStack(R) || MRMgr.onHeap(R)) { // All stack variables are considered to have undefined values // upon creation. All heap allocated blocks are considered to diff --git a/clang/test/Analysis/misc-ps.m b/clang/test/Analysis/misc-ps.m index f7e82be683d..02a7d820208 100644 --- a/clang/test/Analysis/misc-ps.m +++ b/clang/test/Analysis/misc-ps.m @@ -115,4 +115,14 @@ int pr_3543(void) { ({}); } +// <rdar://problem/6611677> +// This test case test the use of a vector type within an array subscript +// expression. +typedef long long __a64vector __attribute__((__vector_size__(8))); +typedef long long __a128vector __attribute__((__vector_size__(16))); +static inline __a64vector __attribute__((__always_inline__, __nodebug__)) +my_test_mm_movepi64_pi64(__a128vector a) { + return (__a64vector)a[0]; +} + |
