diff options
-rw-r--r-- | clang/include/clang/Basic/DiagnosticSemaKinds.td | 2 | ||||
-rw-r--r-- | clang/lib/Sema/SemaCast.cpp | 7 | ||||
-rw-r--r-- | clang/test/CodeGenCXX/dynamic_cast-no-rtti.cpp | 26 | ||||
-rw-r--r-- | clang/test/SemaCXX/no-rtti.cpp | 14 |
4 files changed, 49 insertions, 0 deletions
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td index f6a3515d7f5..6438008a1e4 100644 --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -5036,6 +5036,8 @@ def err_not_tag_in_scope : Error< def err_no_typeid_with_fno_rtti : Error< "cannot use typeid with -fno-rtti">; +def err_no_dynamic_cast_with_fno_rtti : Error< + "cannot use dynamic_cast with -fno-rtti">; def err_cannot_form_pointer_to_member_of_reference_type : Error< "cannot form a pointer-to-member to member %0 of reference type %1">; diff --git a/clang/lib/Sema/SemaCast.cpp b/clang/lib/Sema/SemaCast.cpp index 1adb037f0e9..888c14ec392 100644 --- a/clang/lib/Sema/SemaCast.cpp +++ b/clang/lib/Sema/SemaCast.cpp @@ -667,6 +667,13 @@ void CastOperation::CheckDynamicCast() { Self.MarkVTableUsed(OpRange.getBegin(), cast<CXXRecordDecl>(SrcRecord->getDecl())); + // dynamic_cast is not available with fno-rtti + if (!Self.getLangOpts().RTTI) { + Self.Diag(OpRange.getBegin(), diag::err_no_dynamic_cast_with_fno_rtti); + SrcExpr = ExprError(); + return; + } + // Done. Everything else is run-time checks. Kind = CK_Dynamic; } diff --git a/clang/test/CodeGenCXX/dynamic_cast-no-rtti.cpp b/clang/test/CodeGenCXX/dynamic_cast-no-rtti.cpp new file mode 100644 index 00000000000..2060e1d5453 --- /dev/null +++ b/clang/test/CodeGenCXX/dynamic_cast-no-rtti.cpp @@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -emit-llvm %s -verify -fno-rtti -o - | FileCheck %s +// expected-no-diagnostics + +struct A { + virtual ~A(){}; +}; + +struct B : public A { + B() : A() {} +}; + +// An upcast can be resolved statically and can be used with -fno-rtti, iff it +// does not use runtime support. +A *upcast(B *b) { + return dynamic_cast<A *>(b); +// CHECK: define %struct.A* @_Z6upcastP1B +// CHECK-NOT: call i8* @__dynamic_cast +} + +// A NoOp dynamic_cast can be used with -fno-rtti iff it does not use +// runtime support. +B *samecast(B *b) { + return dynamic_cast<B *>(b); +// CHECK: define %struct.B* @_Z8samecastP1B +// CHECK-NOT: call i8* @__dynamic_cast +} diff --git a/clang/test/SemaCXX/no-rtti.cpp b/clang/test/SemaCXX/no-rtti.cpp index 75167050dca..3d6e109551d 100644 --- a/clang/test/SemaCXX/no-rtti.cpp +++ b/clang/test/SemaCXX/no-rtti.cpp @@ -8,3 +8,17 @@ void f() { (void)typeid(int); // expected-error {{cannot use typeid with -fno-rtti}} } + +namespace { +struct A { + virtual ~A(){}; +}; + +struct B : public A { + B() : A() {} +}; +} + +bool isa_B(A *a) { + return dynamic_cast<B *>(a) != 0; // expected-error {{cannot use dynamic_cast with -fno-rtti}} +} |