diff options
| -rw-r--r-- | clang/lib/Driver/MSVCToolChain.cpp | 12 | ||||
| -rw-r--r-- | clang/lib/Driver/ToolChains.cpp | 11 | ||||
| -rw-r--r-- | clang/lib/Driver/ToolChains.h | 10 | ||||
| -rw-r--r-- | clang/test/Driver/pic.c | 7 |
4 files changed, 7 insertions, 33 deletions
diff --git a/clang/lib/Driver/MSVCToolChain.cpp b/clang/lib/Driver/MSVCToolChain.cpp index 95cf056f7a7..0bbe79c3aa7 100644 --- a/clang/lib/Driver/MSVCToolChain.cpp +++ b/clang/lib/Driver/MSVCToolChain.cpp @@ -82,18 +82,6 @@ bool MSVCToolChain::IsUnwindTablesDefault() const { return getArch() == llvm::Triple::x86_64; } -bool MSVCToolChain::isPICDefault() const { - return getArch() == llvm::Triple::x86_64; -} - -bool MSVCToolChain::isPIEDefault() const { - return false; -} - -bool MSVCToolChain::isPICDefaultForced() const { - return getArch() == llvm::Triple::x86_64; -} - #ifdef USE_WIN32 static bool readFullStringValue(HKEY hkey, const char *valueName, std::string &value) { diff --git a/clang/lib/Driver/ToolChains.cpp b/clang/lib/Driver/ToolChains.cpp index 968b0cb4724..d831ba8adc3 100644 --- a/clang/lib/Driver/ToolChains.cpp +++ b/clang/lib/Driver/ToolChains.cpp @@ -2880,22 +2880,13 @@ bool Generic_GCC::IsUnwindTablesDefault() const { bool Generic_GCC::isPICDefault() const { switch (getArch()) { - case llvm::Triple::x86_64: - return getTriple().isOSWindows(); + default: return false; case llvm::Triple::ppc64: case llvm::Triple::ppc64le: return !getTriple().isOSBinFormatMachO() && !getTriple().isMacOSX(); - default: - return false; } } -bool Generic_GCC::isPIEDefault() const { return false; } - -bool Generic_GCC::isPICDefaultForced() const { - return getArch() == llvm::Triple::x86_64 && getTriple().isOSWindows(); -} - bool Generic_GCC::IsIntegratedAssemblerDefault() const { switch (getTriple().getArch()) { case llvm::Triple::x86: diff --git a/clang/lib/Driver/ToolChains.h b/clang/lib/Driver/ToolChains.h index 7dab08915d4..c8b7931cac8 100644 --- a/clang/lib/Driver/ToolChains.h +++ b/clang/lib/Driver/ToolChains.h @@ -232,8 +232,8 @@ public: bool IsUnwindTablesDefault() const override; bool isPICDefault() const override; - bool isPIEDefault() const override; - bool isPICDefaultForced() const override; + bool isPIEDefault() const override { return false; } + bool isPICDefaultForced() const override { return false; } bool IsIntegratedAssemblerDefault() const override; llvm::opt::DerivedArgList * TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch, @@ -1136,9 +1136,9 @@ public: bool IsIntegratedAssemblerDefault() const override; bool IsUnwindTablesDefault() const override; - bool isPICDefault() const override; - bool isPIEDefault() const override; - bool isPICDefaultForced() const override; + bool isPICDefault() const override { return false; } + bool isPIEDefault() const override { return false; } + bool isPICDefaultForced() const override { return false; } void AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs, diff --git a/clang/test/Driver/pic.c b/clang/test/Driver/pic.c index 9f9d09c54cf..57d1e3fd7dc 100644 --- a/clang/test/Driver/pic.c +++ b/clang/test/Driver/pic.c @@ -255,9 +255,4 @@ // RUN: | FileCheck %s --check-prefix=CHECK-PIC1 // RUN: %clang -c %s -target arm64-linux-android -### 2>&1 \ // RUN: | FileCheck %s --check-prefix=CHECK-PIC1 -// -// On Windows-X64 PIC is enabled by default -// RUN: %clang -c %s -target x86_64-pc-windows-msvc18.0.0 -### 2>&1 \ -// RUN: | FileCheck %s --check-prefix=CHECK-PIC2 -// RUN: %clang -c %s -target x86_64-pc-windows-gnu -### 2>&1 \ -// RUN: | FileCheck %s --check-prefix=CHECK-PIC2 + |

