summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--lldb/include/lldb/Utility/Log.h6
-rw-r--r--lldb/include/lldb/Utility/Logging.h2
-rw-r--r--lldb/source/Initialization/SystemInitializerCommon.cpp2
-rw-r--r--lldb/source/Utility/Log.cpp18
-rw-r--r--lldb/source/Utility/Logging.cpp2
5 files changed, 3 insertions, 27 deletions
diff --git a/lldb/include/lldb/Utility/Log.h b/lldb/include/lldb/Utility/Log.h
index 845ea160b25..d856fc81eb0 100644
--- a/lldb/include/lldb/Utility/Log.h
+++ b/lldb/include/lldb/Utility/Log.h
@@ -96,9 +96,6 @@ public:
}
};
-
- static void Initialize();
-
//------------------------------------------------------------------
// Static accessors for logging channels
//------------------------------------------------------------------
@@ -196,9 +193,6 @@ private:
static uint32_t GetFlags(llvm::raw_ostream &stream, const ChannelMap::value_type &entry,
llvm::ArrayRef<const char *> categories);
- static void LockAllChannels();
- static void UnlockAllChannels();
-
Log(const Log &) = delete;
void operator=(const Log &) = delete;
};
diff --git a/lldb/include/lldb/Utility/Logging.h b/lldb/include/lldb/Utility/Logging.h
index 2c75a3bf218..865097e7c19 100644
--- a/lldb/include/lldb/Utility/Logging.h
+++ b/lldb/include/lldb/Utility/Logging.h
@@ -62,7 +62,7 @@ Log *GetLogIfAllCategoriesSet(uint32_t mask);
Log *GetLogIfAnyCategoriesSet(uint32_t mask);
-void InitializeLldbChannel();
+void InitializeLog();
} // namespace lldb_private
diff --git a/lldb/source/Initialization/SystemInitializerCommon.cpp b/lldb/source/Initialization/SystemInitializerCommon.cpp
index 853547051ff..e76ba4122bb 100644
--- a/lldb/source/Initialization/SystemInitializerCommon.cpp
+++ b/lldb/source/Initialization/SystemInitializerCommon.cpp
@@ -70,7 +70,7 @@ void SystemInitializerCommon::Initialize() {
#endif
llvm::EnablePrettyStackTrace();
- Log::Initialize();
+ InitializeLog();
HostInfo::Initialize();
static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
Timer scoped_timer(func_cat, LLVM_PRETTY_FUNCTION);
diff --git a/lldb/source/Utility/Log.cpp b/lldb/source/Utility/Log.cpp
index ffdb6c4af36..a80b106838b 100644
--- a/lldb/source/Utility/Log.cpp
+++ b/lldb/source/Utility/Log.cpp
@@ -32,7 +32,6 @@
#include <process.h> // for getpid
#else
#include <unistd.h>
-#include <pthread.h>
#endif
using namespace lldb_private;
@@ -182,13 +181,6 @@ void Log::Warning(const char *format, ...) {
Printf("warning: %s", Content.c_str());
}
-void Log::Initialize() {
-#ifdef LLVM_ON_UNIX
- pthread_atfork(&Log::LockAllChannels, &Log::UnlockAllChannels, &Log::UnlockAllChannels);
-#endif
- InitializeLldbChannel();
-}
-
void Log::Register(llvm::StringRef name, Channel &channel) {
auto iter = g_channel_map->try_emplace(name, channel);
assert(iter.second == true);
@@ -329,13 +321,3 @@ void Log::Format(llvm::StringRef file, llvm::StringRef function,
message << payload << "\n";
WriteMessage(message.str());
}
-
-void Log::LockAllChannels() {
- for (auto &c: *g_channel_map)
- c.second.m_mutex.lock();
-}
-
-void Log::UnlockAllChannels() {
- for (auto &c: *g_channel_map)
- c.second.m_mutex.unlock();
-}
diff --git a/lldb/source/Utility/Logging.cpp b/lldb/source/Utility/Logging.cpp
index c9a6ef1bd1e..0bd6d6692e3 100644
--- a/lldb/source/Utility/Logging.cpp
+++ b/lldb/source/Utility/Logging.cpp
@@ -51,7 +51,7 @@ static constexpr Log::Category g_categories[] = {
static Log::Channel g_log_channel(g_categories, LIBLLDB_LOG_DEFAULT);
-void lldb_private::InitializeLldbChannel() {
+void lldb_private::InitializeLog() {
Log::Register("lldb", g_log_channel);
}
OpenPOWER on IntegriCloud