diff options
-rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 8 | ||||
-rw-r--r-- | clang/lib/Sema/SemaTemplate.cpp | 14 | ||||
-rw-r--r-- | clang/test/SemaCXX/delete-and-function-templates.cpp | 115 |
3 files changed, 137 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index b0e79f6f0e7..03f235d4399 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -8630,6 +8630,14 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, NewTemplateDecl->getInstantiatedFromMemberTemplate()) { NewTemplateDecl->setMemberSpecialization(); assert(OldTemplateDecl->isMemberSpecialization()); + // Explicit specializations of a member template do not inherit deleted + // status from the parent member template that they are specializing. + if (OldTemplateDecl->getTemplatedDecl()->isDeleted()) { + FunctionDecl *const OldTemplatedDecl = + OldTemplateDecl->getTemplatedDecl(); + assert(OldTemplatedDecl->getCanonicalDecl() == OldTemplatedDecl); + OldTemplatedDecl->setDeletedAsWritten(false); + } } } else { diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp index d840e426d7a..3833e2c3f07 100644 --- a/clang/lib/Sema/SemaTemplate.cpp +++ b/clang/lib/Sema/SemaTemplate.cpp @@ -6978,6 +6978,13 @@ bool Sema::CheckFunctionTemplateSpecialization( // Mark the prior declaration as an explicit specialization, so that later // clients know that this is an explicit specialization. if (!isFriend) { + // Explicit specializations do not inherit '=delete' from their primary
+ // function template.
+ if (Specialization->isDeleted()) {
+ assert(!SpecInfo->isExplicitSpecialization());
+ assert(Specialization->getCanonicalDecl() == Specialization);
+ Specialization->setDeletedAsWritten(false);
+ } SpecInfo->setTemplateSpecializationKind(TSK_ExplicitSpecialization); MarkUnusedFileScopedDecl(Specialization); } @@ -7137,6 +7144,13 @@ Sema::CheckMemberSpecialization(NamedDecl *Member, LookupResult &Previous) { InstantiationFunction->setTemplateSpecializationKind( TSK_ExplicitSpecialization); InstantiationFunction->setLocation(Member->getLocation()); + // Explicit specializations of member functions of class templates do not + // inherit '=delete' from the member function they are specializing. + if (InstantiationFunction->isDeleted()) { + assert(InstantiationFunction->getCanonicalDecl() == + InstantiationFunction); + InstantiationFunction->setDeletedAsWritten(false);
+ } } cast<FunctionDecl>(Member)->setInstantiationOfMemberFunction( diff --git a/clang/test/SemaCXX/delete-and-function-templates.cpp b/clang/test/SemaCXX/delete-and-function-templates.cpp new file mode 100644 index 00000000000..418aa80e2fd --- /dev/null +++ b/clang/test/SemaCXX/delete-and-function-templates.cpp @@ -0,0 +1,115 @@ +// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only -fms-extensions %s +// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only -fdelayed-template-parsing -fms-extensions %s + +template<class T, class U> struct is_same { enum { value = false }; }; +template<class T> struct is_same<T, T> { enum { value = true }; }; + +namespace test_sfinae_and_delete { + +namespace ns1 { +template<class T> double f(T) = delete; //expected-note{{candidate}} +char f(...); //expected-note{{candidate}} + +static_assert(is_same<decltype(f(3)),char>::value, ""); //expected-error{{call to deleted function}} expected-error{{static_assert failed}} + +template<class T> decltype(f(T{})) g(T); // this one sfinae's out. +template<class T> int *g(T); +void foo() { + int *ip = g(3); +} +} //end ns1 + +namespace ns2 { +template<class T> double* f(T); +template<> double* f(double) = delete; + +template<class T> decltype(f(T{})) g(T); // expected-note{{candidate}} +template<class T> int *g(T); //expected-note{{candidate}} +void foo() { + double *dp = g(3); //expected-error{{ambiguous}} + int *ip = g(3.14); // this is OK - because the explicit specialization is deleted and sfinae's out one of the template candidates +} + +} // end ns2 + +namespace ns3 { +template<class T> double* f(T) = delete; +template<> double* f(double); + +template<class T> decltype(f(T{})) g(T); // expected-note{{candidate}} +template<class T> int *g(T); //expected-note{{candidate}} + +void foo() { + int *dp = g(3); // this is OK - because the non-double specializations are deleted and sfinae's out one of the template candidates + double *ip = g(3.14); //expected-error{{ambiguous}} +} + +} // end ns3 +} // end ns test_sfinae_and_delete + +namespace test_explicit_specialization_of_member { +namespace ns1 { +template<class T> struct X { + int* f(T) = delete; +}; +template<> int* X<int>::f(int) { } + +template<class T> decltype(X<T>{}.f(T{})) g(T); // expected-note{{candidate}} +template<class T> int *g(T); //expected-note{{candidate}} + +void foo() { + int *ip2 = g(3.14); // this is OK - because the non-int specializations are deleted and sfinae's out one of the template candidates + int *ip = g(3); //expected-error{{ambiguous}} +} + +} // end ns1 + +namespace ns2 { +struct X { +template<class T> double* f(T) = delete; +}; +template<> double* X::f(int); + +template<class T> decltype(X{}.f(T{})) g(T); // expected-note{{candidate}} +template<class T> int *g(T); //expected-note{{candidate}} + +void foo() { + int *ip2 = g(3.14); // this is OK - because the non-int specializations are deleted and sfinae's out one of the template candidates + int *ip = g(3); //expected-error{{ambiguous}} +} + +} // end ns2 + +namespace ns3 { +template<class T> struct X { + template<class U> double *f1(U, T) = delete; + template<class U> double *f2(U, T) = delete; +}; +template<> template<> double* X<int>::f1(int, int); +template<> template<class U> double* X<int>::f2(U, int); + +template<class T, class U> decltype(X<T>{}.f1(U{}, T{})) g1(U, T); // expected-note{{candidate}} +template<class T, class U> int *g1(U, T); //expected-note{{candidate}} + +template<class T, class U> decltype(X<T>{}.f2(U{}, T{})) g2(U, T); // expected-note2{{candidate}} +template<class T, class U> int *g2(U, T); //expected-note2{{candidate}} + + +void foo() { + int *ip2 = g1(3.14, 3); // this is OK - because the non-int specializations are deleted and sfinae's out one of the template candidates + int *ip = g1(3, 3); //expected-error{{ambiguous}} + { + int *ip3 = g2(3.14, 3); //expected-error{{ambiguous}} + int *ip4 = g2(3, 3); //expected-error{{ambiguous}} + } + { + int *ip3 = g2(3.14, 3.14); + int *ip4 = g2(3, 3.14); + } +} + + +} // end ns3 +} // end test_explicit_specializations_and_delete |