diff options
| -rw-r--r-- | clang/lib/Sema/SemaDeclCXX.cpp | 10 | ||||
| -rw-r--r-- | clang/test/SemaCXX/libstdcxx_gets_hack.cpp | 28 |
2 files changed, 38 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 47c1af9ad3a..02b73e9113f 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -9135,6 +9135,16 @@ NamedDecl *Sema::BuildUsingDeclaration(Scope *S, AccessSpecifier AS, // invalid). if (R.empty() && NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) { + // HACK: Work around a bug in libstdc++'s detection of ::gets. Sometimes + // it will believe that glibc provides a ::gets in cases where it does not, + // and will try to pull it into namespace std with a using-declaration. + // Just ignore the using-declaration in that case. + auto *II = NameInfo.getName().getAsIdentifierInfo(); + if (getLangOpts().CPlusPlus14 && II && II->isStr("gets") && + CurContext->isStdNamespace() && + isa<TranslationUnitDecl>(LookupContext) && + getSourceManager().isInSystemHeader(UsingLoc)) + return nullptr; if (TypoCorrection Corrected = CorrectTypo( R.getLookupNameInfo(), R.getLookupKind(), S, &SS, llvm::make_unique<UsingValidatorCCC>( diff --git a/clang/test/SemaCXX/libstdcxx_gets_hack.cpp b/clang/test/SemaCXX/libstdcxx_gets_hack.cpp new file mode 100644 index 00000000000..0d915d01474 --- /dev/null +++ b/clang/test/SemaCXX/libstdcxx_gets_hack.cpp @@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -fsyntax-only %s -std=c++14 -verify + +// This is a test for an egregious hack in Clang that works around +// an issue with libstdc++'s detection of whether glibc provides a +// ::gets function. If there is no ::gets, ignore +// using ::gets; +// in namespace std. +// +// See PR18402 and gcc.gnu.org/PR77795 for more details. + +#ifdef BE_THE_HEADER + +#pragma GCC system_header +namespace std { + using ::gets; + using ::getx; // expected-error {{no member named 'getx'}} +} + +#else + +#define BE_THE_HEADER +#include "libstdcxx_pointer_return_false_hack.cpp" + +namespace foo { + using ::gets; // expected-error {{no member named 'gets'}} +} + +#endif |
