diff options
-rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 6 | ||||
-rw-r--r-- | llvm/test/CodeGen/PowerPC/setcc-logic.ll | 14 | ||||
-rw-r--r-- | llvm/test/CodeGen/X86/setcc-logic.ll | 8 |
3 files changed, 12 insertions, 16 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 63b362d3a37..3f68390b814 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -3214,8 +3214,10 @@ SDValue DAGCombiner::foldAndOfSetCCs(SDValue N0, SDValue N1, const SDLoc &DL) { // All bits set? // (and (seteq X, -1), (seteq Y, -1)) --> (seteq (and X, Y), -1) - // TODO: All sign bits set? - if (isAllOnesConstant(LR) && CC1 == ISD::SETEQ) { + // All sign bits set? + // (and (setlt X, 0), (setlt Y, 0)) --> (setlt (and X, Y), 0) + if ((isAllOnesConstant(LR) && CC1 == ISD::SETEQ) || + (isNullConstant(LR) && CC1 == ISD::SETLT)) { SDValue And = DAG.getNode(ISD::AND, SDLoc(N0), OpVT, LL, RL); AddToWorklist(And.getNode()); return DAG.getSetCC(DL, VT, And, LR, CC1); diff --git a/llvm/test/CodeGen/PowerPC/setcc-logic.ll b/llvm/test/CodeGen/PowerPC/setcc-logic.ll index f7f2caa190a..38db2a8bcef 100644 --- a/llvm/test/CodeGen/PowerPC/setcc-logic.ll +++ b/llvm/test/CodeGen/PowerPC/setcc-logic.ll @@ -45,11 +45,8 @@ define zeroext i1 @all_bits_set(i32 %P, i32 %Q) { define zeroext i1 @all_sign_bits_set(i32 %P, i32 %Q) { ; CHECK-LABEL: all_sign_bits_set: ; CHECK: # BB#0: -; CHECK-NEXT: cmpwi 0, 3, 0 -; CHECK-NEXT: cmpwi 1, 4, 0 -; CHECK-NEXT: li 3, 1 -; CHECK-NEXT: crnand 20, 0, 4 -; CHECK-NEXT: isel 3, 0, 3, 20 +; CHECK-NEXT: and 3, 3, 4 +; CHECK-NEXT: srwi 3, 3, 31 ; CHECK-NEXT: blr %a = icmp slt i32 %P, 0 %b = icmp slt i32 %Q, 0 @@ -188,10 +185,9 @@ return: define i32 @all_sign_bits_set_branch(i32 %P, i32 %Q) { ; CHECK-LABEL: all_sign_bits_set_branch: ; CHECK: # BB#0: # %entry -; CHECK-NEXT: cmpwi 0, 3, 0 -; CHECK-NEXT: cmpwi 1, 4, 0 -; CHECK-NEXT: crand 20, 0, 4 -; CHECK-NEXT: bc 4, 20, .LBB11_2 +; CHECK-NEXT: and 3, 3, 4 +; CHECK-NEXT: cmpwi 0, 3, -1 +; CHECK-NEXT: bgt 0, .LBB11_2 ; CHECK-NEXT: # BB#1: # %bb1 ; CHECK-NEXT: li 3, 4 ; CHECK-NEXT: blr diff --git a/llvm/test/CodeGen/X86/setcc-logic.ll b/llvm/test/CodeGen/X86/setcc-logic.ll index eca33130ecb..15b36b29ec5 100644 --- a/llvm/test/CodeGen/X86/setcc-logic.ll +++ b/llvm/test/CodeGen/X86/setcc-logic.ll @@ -41,11 +41,9 @@ define zeroext i1 @all_bits_set(i32 %P, i32 %Q) nounwind { define zeroext i1 @all_sign_bits_set(i32 %P, i32 %Q) nounwind { ; CHECK-LABEL: all_sign_bits_set: ; CHECK: # BB#0: -; CHECK-NEXT: testl %edi, %edi -; CHECK-NEXT: sets %cl -; CHECK-NEXT: testl %esi, %esi -; CHECK-NEXT: sets %al -; CHECK-NEXT: andb %cl, %al +; CHECK-NEXT: andl %esi, %edi +; CHECK-NEXT: shrl $31, %edi +; CHECK-NEXT: movl %edi, %eax ; CHECK-NEXT: retq %a = icmp slt i32 %P, 0 %b = icmp slt i32 %Q, 0 |