diff options
| -rw-r--r-- | llvm/docs/OptBisect.rst | 11 | ||||
| -rw-r--r-- | llvm/include/llvm/IR/OptBisect.h | 18 | ||||
| -rw-r--r-- | llvm/lib/IR/OptBisect.cpp | 18 |
3 files changed, 2 insertions, 45 deletions
diff --git a/llvm/docs/OptBisect.rst b/llvm/docs/OptBisect.rst index 14eb57bc7d5..5a216d419a6 100644 --- a/llvm/docs/OptBisect.rst +++ b/llvm/docs/OptBisect.rst @@ -189,12 +189,5 @@ Adding Finer Granularity Once the pass in which an incorrect transformation is performed has been determined, it may be useful to perform further analysis in order to determine -which specific transformation is causing the problem. Ideally all passes -would be instrumented to allow skipping of individual transformations. This -functionality is available through the OptBisect object but it is impractical -to proactively instrument every existing pass. It is hoped that as developers -find that they need a pass to be instrumented they will add the instrumentation -and contribute it back to the LLVM source base. - -Helper functions will be added to simplify this level of instrumentation, but -this work is not yet completed. For more information, contact Andy Kaylor. +which specific transformation is causing the problem. Debug counters +can be used for this purpose. diff --git a/llvm/include/llvm/IR/OptBisect.h b/llvm/include/llvm/IR/OptBisect.h index 9eee65e93e5..185a5ac956f 100644 --- a/llvm/include/llvm/IR/OptBisect.h +++ b/llvm/include/llvm/IR/OptBisect.h @@ -51,24 +51,6 @@ public: template <class UnitT> bool shouldRunPass(const Pass *P, const UnitT &U); - /// Checks the bisect limit to determine if the optimization described by the - /// /p Desc argument should run. - /// - /// This function will immediate return true if bisection is disabled. If the - /// bisect limit is set to -1, the function will print a message with the - /// bisect number assigned to the optimization along with the /p Desc - /// description and return true. Otherwise, the function will print a message - /// with the bisect number assigned to the optimization and indicating whether - /// or not the pass will be run and return true if the bisect limit has not - /// yet been exceded or false if it has. - /// - /// Passes may call this function to provide more fine grained control over - /// individual optimizations performed by the pass. Passes which cannot be - /// skipped entirely (such as non-optional code generation passes) may still - /// call this function to control whether or not individual optional - /// transformations are performed. - bool shouldRunCase(const Twine &Desc); - private: bool checkPass(const StringRef PassName, const StringRef TargetDesc); diff --git a/llvm/lib/IR/OptBisect.cpp b/llvm/lib/IR/OptBisect.cpp index e9574ca8126..b670c817569 100644 --- a/llvm/lib/IR/OptBisect.cpp +++ b/llvm/lib/IR/OptBisect.cpp @@ -39,14 +39,6 @@ static void printPassMessage(const StringRef &Name, int PassNum, << "(" << PassNum << ") " << Name << " on " << TargetDesc << "\n"; } -static void printCaseMessage(int CaseNum, StringRef Msg, bool Running) { - if (Running) - errs() << "BISECT: running case ("; - else - errs() << "BISECT: NOT running case ("; - errs() << CaseNum << "): " << Msg << "\n"; -} - static std::string getDescription(const Module &M) { return "module (" + M.getName().str() + ")"; } @@ -108,13 +100,3 @@ bool OptBisect::checkPass(const StringRef PassName, printPassMessage(PassName, CurBisectNum, TargetDesc, ShouldRun); return ShouldRun; } - -bool OptBisect::shouldRunCase(const Twine &Msg) { - if (!BisectEnabled) - return true; - int CurFuelNum = ++LastBisectNum; - bool ShouldRun = (OptBisectLimit == -1 || CurFuelNum <= OptBisectLimit); - printCaseMessage(CurFuelNum, Msg.str(), ShouldRun); - return ShouldRun; -} - |
