diff options
author | Samuel Antao <sfantao@us.ibm.com> | 2016-03-12 00:55:17 +0000 |
---|---|---|
committer | Samuel Antao <sfantao@us.ibm.com> | 2016-03-12 00:55:17 +0000 |
commit | 11e4c539f473aba9e09cab92fc1fdfb753b6a17e (patch) | |
tree | 6f85a9d1eae678ab54d19fef5217aa1920850846 /openmp | |
parent | 73a0dac96d8c4a59caf9447f97ddae1a3133f4d5 (diff) | |
download | bcm5719-llvm-11e4c539f473aba9e09cab92fc1fdfb753b6a17e.tar.gz bcm5719-llvm-11e4c539f473aba9e09cab92fc1fdfb753b6a17e.zip |
Initialize two variables in kmp_tasking.
Summary:
Two initialized local variables are causing clang to produce warnings:
```
./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'num_tasks' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3027:21: note: uninitialized use occurs here
for( i = 0; i < num_tasks; ++i ) {
^~~~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:28: note: initialize the variable 'num_tasks' to silence this warning
kmp_uint64 i, num_tasks, extras;
^
= 0
./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'extras' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3022:52: note: uninitialized use occurs here
KMP_DEBUG_ASSERT(tc == num_tasks * grainsize + extras);
^~~~~~
./src/projects/openmp/runtime/src/kmp_debug.h:62:60: note: expanded from macro 'KMP_DEBUG_ASSERT'
#define KMP_DEBUG_ASSERT( cond ) KMP_ASSERT( cond )
^
./src/projects/openmp/runtime/src/kmp_debug.h:60:51: note: expanded from macro 'KMP_ASSERT'
#define KMP_ASSERT( cond ) ( (cond) ? 0 : __kmp_debug_assert( #cond, __FILE__, __LINE__ ) )
^
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:36: note: initialize the variable 'extras' to silence this warning
kmp_uint64 i, num_tasks, extras;
^
= 0
2 errors generated.
```
This patch initializes these two variables.
Reviewers: tlwilmar, jlpeyton
Subscribers: tlwilmar, openmp-commits
Differential Revision: http://reviews.llvm.org/D17909
llvm-svn: 263316
Diffstat (limited to 'openmp')
-rw-r--r-- | openmp/runtime/src/kmp_tasking.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/openmp/runtime/src/kmp_tasking.c b/openmp/runtime/src/kmp_tasking.c index 3cfd3c53ab5..1122c49f3f3 100644 --- a/openmp/runtime/src/kmp_tasking.c +++ b/openmp/runtime/src/kmp_tasking.c @@ -2965,7 +2965,7 @@ __kmp_taskloop_linear(ident_t *loc, int gtid, kmp_task_t *task, kmp_uint64 tc; kmp_uint64 lower = *lb; // compiler provides global bounds here kmp_uint64 upper = *ub; - kmp_uint64 i, num_tasks, extras; + kmp_uint64 i, num_tasks = 0, extras = 0; kmp_info_t *thread = __kmp_threads[gtid]; kmp_taskdata_t *current_task = thread->th.th_current_task; kmp_task_t *next_task; |