diff options
| author | Alex Zinenko <zinenko@google.com> | 2019-08-09 10:45:15 -0700 |
|---|---|---|
| committer | A. Unique TensorFlower <gardener@tensorflow.org> | 2019-08-09 10:45:44 -0700 |
| commit | baa1ec22f742c3e1545404cb30d2073b87c7271b (patch) | |
| tree | 238e87c1452edfb9b1ccffda6729c5928ef1c021 /mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp | |
| parent | 68451df267eda7961fca930ab29c6d38f43b97e2 (diff) | |
| download | bcm5719-llvm-baa1ec22f742c3e1545404cb30d2073b87c7271b.tar.gz bcm5719-llvm-baa1ec22f742c3e1545404cb30d2073b87c7271b.zip | |
Translation to LLVM IR: use LogicalResult instead of bool
The translation code predates the introduction of LogicalResult and was relying
on the obsolete LLVM convention of returning false on success. Change it to
use MLIR's LogicalResult abstraction instead. NFC.
PiperOrigin-RevId: 262589432
Diffstat (limited to 'mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp')
| -rw-r--r-- | mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp b/mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp index 5c34ed160b2..150fb7cfb97 100644 --- a/mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp +++ b/mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp @@ -164,7 +164,7 @@ static bool emitOneBuilder(const Record &record, raw_ostream &os) { os << "if (auto op = dyn_cast<" << op.getQualCppClassName() << ">(opInst)) {\n"; os << bs.str() << builderStrRef << "\n"; - os << " return false;\n"; + os << " return success();\n"; os << "}\n"; return true; |
