diff options
| author | Aart Bik <ajcbik@google.com> | 2019-12-19 11:47:45 -0800 |
|---|---|---|
| committer | A. Unique TensorFlower <gardener@tensorflow.org> | 2019-12-19 11:51:08 -0800 |
| commit | 15f800f4bc71733c9f47f0dc4d44799be900bc00 (patch) | |
| tree | 769ced04e0b9ed29edffa10a97bc38d72e04a507 /mlir/test/Dialect/VectorOps | |
| parent | efadb6b8388344bcf13b739fdc22dd8812df5b3b (diff) | |
| download | bcm5719-llvm-15f800f4bc71733c9f47f0dc4d44799be900bc00.tar.gz bcm5719-llvm-15f800f4bc71733c9f47f0dc4d44799be900bc00.zip | |
[VectorOps] minor cleanup: vector dialect "subscripts" are i32
Introduces some centralized methods to move towards
consistent use of i32 as vector subscripts.
Note: sizes/strides/offsets attributes are still i64
PiperOrigin-RevId: 286434133
Diffstat (limited to 'mlir/test/Dialect/VectorOps')
| -rw-r--r-- | mlir/test/Dialect/VectorOps/invalid.mlir | 8 | ||||
| -rw-r--r-- | mlir/test/Dialect/VectorOps/ops.mlir | 16 |
2 files changed, 12 insertions, 12 deletions
diff --git a/mlir/test/Dialect/VectorOps/invalid.mlir b/mlir/test/Dialect/VectorOps/invalid.mlir index 7e8fce93294..d79c0350910 100644 --- a/mlir/test/Dialect/VectorOps/invalid.mlir +++ b/mlir/test/Dialect/VectorOps/invalid.mlir @@ -67,9 +67,9 @@ func @shuffle_empty_mask(%arg0: vector<2xf32>, %arg1: vector<2xf32>) { // ----- func @extract_element(%arg0: vector<4x4xf32>) { - %c = constant 3 : index + %c = constant 3 : i32 // expected-error@+1 {{'vector.extractelement' op expected 1-D vector}} - %1 = vector.extractelement %arg0[%c : index] : vector<4x4xf32> + %1 = vector.extractelement %arg0[%c : i32] : vector<4x4xf32> } // ----- @@ -124,9 +124,9 @@ func @extract_position_overflow(%arg0: vector<4x8x16xf32>) { // ----- func @insert_element(%arg0: f32, %arg1: vector<4x4xf32>) { - %c = constant 3 : index + %c = constant 3 : i32 // expected-error@+1 {{'vector.insertelement' op expected 1-D vector}} - %0 = vector.insertelement %arg0, %arg1[%c : index] : vector<4x4xf32> + %0 = vector.insertelement %arg0, %arg1[%c : i32] : vector<4x4xf32> } // ----- diff --git a/mlir/test/Dialect/VectorOps/ops.mlir b/mlir/test/Dialect/VectorOps/ops.mlir index b43c675893e..06d57289363 100644 --- a/mlir/test/Dialect/VectorOps/ops.mlir +++ b/mlir/test/Dialect/VectorOps/ops.mlir @@ -55,10 +55,10 @@ func @shuffle2D(%a: vector<1x4xf32>, %b: vector<2x4xf32>) -> vector<3x4xf32> { // CHECK-LABEL: @extract_element func @extract_element(%a: vector<16xf32>) -> f32 { - // CHECK: %[[C15:.*]] = constant 15 : index - %c = constant 15 : index - // CHECK-NEXT: vector.extractelement %{{.*}}[%[[C15]] : index] : vector<16xf32> - %1 = vector.extractelement %a[%c : index] : vector<16xf32> + // CHECK: %[[C15:.*]] = constant 15 : i32 + %c = constant 15 : i32 + // CHECK-NEXT: vector.extractelement %{{.*}}[%[[C15]] : i32] : vector<16xf32> + %1 = vector.extractelement %a[%c : i32] : vector<16xf32> return %1 : f32 } @@ -75,10 +75,10 @@ func @extract(%arg0: vector<4x8x16xf32>) -> (vector<8x16xf32>, vector<16xf32>, f // CHECK-LABEL: @insert_element func @insert_element(%a: f32, %b: vector<16xf32>) -> vector<16xf32> { - // CHECK: %[[C15:.*]] = constant 15 : index - %c = constant 15 : index - // CHECK-NEXT: vector.insertelement %{{.*}}, %{{.*}}[%[[C15]] : index] : vector<16xf32> - %1 = vector.insertelement %a, %b[%c : index] : vector<16xf32> + // CHECK: %[[C15:.*]] = constant 15 : i32 + %c = constant 15 : i32 + // CHECK-NEXT: vector.insertelement %{{.*}}, %{{.*}}[%[[C15]] : i32] : vector<16xf32> + %1 = vector.insertelement %a, %b[%c : i32] : vector<16xf32> return %1 : vector<16xf32> } |

