Rename convenience methods to make type explicit.

PiperOrigin-RevId: 226939383

3 files changed, 9 insertions, 5 deletions

diff --git a/mlir/lib/IR/Builders.cpp b/mlir/lib/IR/Builders.cpp
index 7ecc5e9f090..67b09c5aa6e 100644
--- a/mlir/lib/IR/Builders.cpp
+++ b/mlir/lib/IR/Builders.cpp
@@ -121,10 +121,14 @@ BoolAttr Builder::getBoolAttr(bool value) {
   return BoolAttr::get(value, context);
 }
 
-IntegerAttr Builder::getIntegerAttr(int64_t value) {
+IntegerAttr Builder::getI64IntegerAttr(int64_t value) {
   return IntegerAttr::get(getIntegerType(64), APInt(64, value));
 }
 
+IntegerAttr Builder::getI32IntegerAttr(int32_t value) {
+  return IntegerAttr::get(getIntegerType(32), APInt(32, value));
+}
+
 IntegerAttr Builder::getIntegerAttr(Type type, int64_t value) {
   if (type.isIndex())
     return IntegerAttr::get(type, APInt(64, value));
@@ -135,11 +139,11 @@ IntegerAttr Builder::getIntegerAttr(Type type, const APInt &value) {
   return IntegerAttr::get(type, value);
 }
 
-FloatAttr Builder::getFloatAttr(double value) {
+FloatAttr Builder::getF64FloatAttr(double value) {
   return FloatAttr::get(getF64Type(), APFloat(value));
 }
 
-FloatAttr Builder::getFloatAttr(float value) {
+FloatAttr Builder::getF32FloatAttr(float value) {
   return FloatAttr::get(getF32Type(), APFloat(value));
 }
 
diff --git a/mlir/lib/StandardOps/StandardOps.cpp b/mlir/lib/StandardOps/StandardOps.cpp
index c1ad9763518..9613c56daf0 100644
--- a/mlir/lib/StandardOps/StandardOps.cpp
+++ b/mlir/lib/StandardOps/StandardOps.cpp
@@ -535,7 +535,7 @@ bool CmpIOp::parse(OpAsmParser *parser, OperationState *result) {
                              "unknown comparison predicate \"" +
                                  Twine(predicateName.getValue()) + "\"");
   auto builder = parser->getBuilder();
-  attrs[0].second = builder.getIntegerAttr(static_cast<int64_t>(predicate));
+  attrs[0].second = builder.getI64IntegerAttr(static_cast<int64_t>(predicate));
   result->attributes = attrs;
 
   result->addTypes({getI1SameShape(&builder, type)});
diff --git a/mlir/lib/Transforms/PipelineDataTransfer.cpp b/mlir/lib/Transforms/PipelineDataTransfer.cpp
index 8d75bfbd7ae..13d3ea92307 100644
--- a/mlir/lib/Transforms/PipelineDataTransfer.cpp
+++ b/mlir/lib/Transforms/PipelineDataTransfer.cpp
@@ -357,7 +357,7 @@ PassResult PipelineDataTransfer::runOnForStmt(ForStmt *forStmt) {
         if (auto *opStmt = dyn_cast<OperationStmt>(&stmt)) {
           MLFuncBuilder b(opStmt);
           opStmt->setAttr(b.getIdentifier("shift"),
-                          b.getIntegerAttr(shifts[s - 1]));
+                          b.getI64IntegerAttr(shifts[s - 1]));
         });
   }