Add -tile-sizes command line option for loop tiling; clean up cl options for

for dma-generate, loop-unroll.

- add -tile-sizes command line option for loop tiling to specify different tile
  sizes for loops in a band

- clean up command line options for loop-unroll, dma-generate (remove
  cl::hidden)

PiperOrigin-RevId: 234006232

1 files changed, 20 insertions, 10 deletions

diff --git a/mlir/lib/Transforms/LoopTiling.cpp b/mlir/lib/Transforms/LoopTiling.cpp
index 368a1dac1df..b86516f31f7 100644
--- a/mlir/lib/Transforms/LoopTiling.cpp
+++ b/mlir/lib/Transforms/LoopTiling.cpp
@@ -36,11 +36,13 @@ using namespace mlir;
 
 static llvm::cl::OptionCategory clOptionsCategory(DEBUG_TYPE " options");
 
-// Tile size for all loops.
-static llvm::cl::opt<unsigned>
-    clTileSize("tile-size", llvm::cl::Hidden,
-               llvm::cl::desc("Use this tile size for all loops"),
-               llvm::cl::cat(clOptionsCategory));
+// List of tile sizes. If any of them aren't provided, they are filled with
+// clTileSize.
+static llvm::cl::list<unsigned> clTileSizes(
+    "tile-sizes",
+    llvm::cl::desc(
+        "List of tile sizes for each perfect nest (overrides -tile-size)"),
+    llvm::cl::ZeroOrMore, llvm::cl::cat(clOptionsCategory));
 
 namespace {
 
@@ -57,6 +59,12 @@ struct LoopTiling : public FunctionPass {
 
 char LoopTiling::passID = 0;
 
+// Tile size to use for all loops (overridden by -tile-sizes if provided).
+static llvm::cl::opt<unsigned>
+    clTileSize("tile-size", llvm::cl::init(LoopTiling::kDefaultTileSize),
+               llvm::cl::desc("Use this tile size for all loops"),
+               llvm::cl::cat(clOptionsCategory));
+
 /// Creates a pass to perform loop tiling on all suitable loop nests of an
 /// Function.
 FunctionPass *mlir::createLoopTilingPass() { return new LoopTiling(); }
@@ -252,12 +260,14 @@ PassResult LoopTiling::runOnFunction(Function *f) {
   std::vector<SmallVector<OpPointer<AffineForOp>, 6>> bands;
   getTileableBands(f, &bands);
 
-  // Temporary tile sizes.
-  unsigned tileSize =
-      clTileSize.getNumOccurrences() > 0 ? clTileSize : kDefaultTileSize;
-
   for (auto &band : bands) {
-    SmallVector<unsigned, 6> tileSizes(band.size(), tileSize);
+    // Set up tile sizes; fill missing tile sizes at the end with default tile
+    // size or clTileSize if one was provided.
+    SmallVector<unsigned, 6> tileSizes(band.size(), clTileSize);
+    std::copy(clTileSizes.begin(),
+              clTileSizes.begin() + std::min(clTileSizes.size(), band.size()),
+              tileSizes.begin());
+
     if (tileCodeGen(band, tileSizes)) {
       return failure();
     }