NFC: Refactor Function to be value typed.

Move the data members out of Function and into a new impl storage class 'FunctionStorage'. This allows for Function to become value typed, which will greatly simplify the transition of Function to FuncOp(given that FuncOp is also value typed).

PiperOrigin-RevId: 255983022

1 files changed, 5 insertions, 5 deletions

diff --git a/mlir/lib/ExecutionEngine/MemRefUtils.cpp b/mlir/lib/ExecutionEngine/MemRefUtils.cpp
index 51636037382..f13b743de0c 100644
--- a/mlir/lib/ExecutionEngine/MemRefUtils.cpp
+++ b/mlir/lib/ExecutionEngine/MemRefUtils.cpp
@@ -67,10 +67,10 @@ allocMemRefDescriptor(Type type, bool allocateData = true,
 }
 
 llvm::Expected<SmallVector<void *, 8>>
-mlir::allocateMemRefArguments(Function *func, float initialValue) {
+mlir::allocateMemRefArguments(Function func, float initialValue) {
   SmallVector<void *, 8> args;
-  args.reserve(func->getNumArguments());
-  for (const auto &arg : func->getArguments()) {
+  args.reserve(func.getNumArguments());
+  for (const auto &arg : func.getArguments()) {
     auto descriptor =
         allocMemRefDescriptor(arg->getType(),
                               /*allocateData=*/true, initialValue);
@@ -79,10 +79,10 @@ mlir::allocateMemRefArguments(Function *func, float initialValue) {
     args.push_back(*descriptor);
   }
 
-  if (func->getType().getNumResults() > 1)
+  if (func.getType().getNumResults() > 1)
     return make_string_error("functions with more than 1 result not supported");
 
-  for (Type resType : func->getType().getResults()) {
+  for (Type resType : func.getType().getResults()) {
     auto descriptor = allocMemRefDescriptor(resType, /*allocateData=*/false);
     if (!descriptor)
       return descriptor.takeError();