diff options
| author | Aart Bik <ajcbik@google.com> | 2019-11-26 19:52:02 -0800 |
|---|---|---|
| committer | A. Unique TensorFlower <gardener@tensorflow.org> | 2019-11-26 19:52:38 -0800 |
| commit | e2232fbcee8a4bf4e2a6ab181f8fabb57633dda6 (patch) | |
| tree | 826c3e2f33dab6d38433ac7fa6ec6f9d81c6d72c /mlir/lib/Dialect/VectorOps/VectorOps.cpp | |
| parent | f27ceb726188d0b16c979fddf644e33886139006 (diff) | |
| download | bcm5719-llvm-e2232fbcee8a4bf4e2a6ab181f8fabb57633dda6.tar.gz bcm5719-llvm-e2232fbcee8a4bf4e2a6ab181f8fabb57633dda6.zip | |
[VectorOps] Refine BroadcastOp in VectorOps dialect
Since second argument is always fully overwritten and
shape is define in "to" clause, it is not needed.
Also renamed "into" to "to" now that arg is dropped.
PiperOrigin-RevId: 282686475
Diffstat (limited to 'mlir/lib/Dialect/VectorOps/VectorOps.cpp')
| -rw-r--r-- | mlir/lib/Dialect/VectorOps/VectorOps.cpp | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/mlir/lib/Dialect/VectorOps/VectorOps.cpp b/mlir/lib/Dialect/VectorOps/VectorOps.cpp index d09fd0fc2f2..fe320b91439 100644 --- a/mlir/lib/Dialect/VectorOps/VectorOps.cpp +++ b/mlir/lib/Dialect/VectorOps/VectorOps.cpp @@ -373,14 +373,14 @@ static LogicalResult verify(ExtractElementOp op) { //===----------------------------------------------------------------------===// static void print(OpAsmPrinter &p, BroadcastOp op) { - p << op.getOperationName() << " " << *op.source() << ", " << *op.dest(); + p << op.getOperationName() << " " << *op.source(); p << " : " << op.getSourceType(); - p << " into " << op.getDestVectorType(); + p << " to " << op.getVectorType(); } static LogicalResult verify(BroadcastOp op) { VectorType srcVectorType = op.getSourceType().dyn_cast<VectorType>(); - VectorType dstVectorType = op.getDestVectorType(); + VectorType dstVectorType = op.getVectorType(); // Scalar to vector broadcast is always valid. A vector // to vector broadcast needs some additional checking. if (srcVectorType) { @@ -397,16 +397,14 @@ static LogicalResult verify(BroadcastOp op) { static ParseResult parseBroadcastOp(OpAsmParser &parser, OperationState &result) { - OpAsmParser::OperandType source, dest; + OpAsmParser::OperandType source; Type sourceType; - VectorType destType; - return failure(parser.parseOperand(source) || parser.parseComma() || - parser.parseOperand(dest) || + VectorType vectorType; + return failure(parser.parseOperand(source) || parser.parseColonType(sourceType) || - parser.parseKeywordType("into", destType) || + parser.parseKeywordType("to", vectorType) || parser.resolveOperand(source, sourceType, result.operands) || - parser.resolveOperand(dest, destType, result.operands) || - parser.addTypeToList(destType, result.types)); + parser.addTypeToList(vectorType, result.types)); } //===----------------------------------------------------------------------===// |

