diff options
author | River Riddle <riverriddle@google.com> | 2019-08-05 18:37:56 -0700 |
---|---|---|
committer | A. Unique TensorFlower <gardener@tensorflow.org> | 2019-08-05 18:38:22 -0700 |
commit | a0df3ebd15e84eab052ebf1f9e8cd4e561f7b4aa (patch) | |
tree | c213b80e754258a3998d50d38afa84a792951bea /mlir/lib/Dialect/QuantOps/Transforms | |
parent | 3657966e839125bd26edbdf00c874ad1868b038a (diff) | |
download | bcm5719-llvm-a0df3ebd15e84eab052ebf1f9e8cd4e561f7b4aa.tar.gz bcm5719-llvm-a0df3ebd15e84eab052ebf1f9e8cd4e561f7b4aa.zip |
NFC: Implement OwningRewritePatternList as a class instead of a using directive.
This allows for proper forward declaration, as opposed to leaking the internal implementation via a using directive. This also allows for all pattern building to go through 'insert' methods on the OwningRewritePatternList, replacing uses of 'push_back' and 'RewriteListBuilder'.
PiperOrigin-RevId: 261816316
Diffstat (limited to 'mlir/lib/Dialect/QuantOps/Transforms')
-rw-r--r-- | mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp | 2 | ||||
-rw-r--r-- | mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp b/mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp index 8469fa2ea70..2276fbd21c9 100644 --- a/mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp +++ b/mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp @@ -108,7 +108,7 @@ void ConvertConstPass::runOnFunction() { OwningRewritePatternList patterns; auto func = getFunction(); auto *context = &getContext(); - patterns.push_back(llvm::make_unique<QuantizedConstRewrite>(context)); + patterns.insert<QuantizedConstRewrite>(context); applyPatternsGreedily(func, std::move(patterns)); } diff --git a/mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp b/mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp index 32d8c8a81c1..8f5d1b33c64 100644 --- a/mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp +++ b/mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp @@ -97,8 +97,7 @@ void ConvertSimulatedQuantPass::runOnFunction() { OwningRewritePatternList patterns; auto func = getFunction(); auto *context = &getContext(); - patterns.push_back( - llvm::make_unique<ConstFakeQuantRewrite>(context, &hadFailure)); + patterns.insert<ConstFakeQuantRewrite>(context, &hadFailure); applyPatternsGreedily(func, std::move(patterns)); if (hadFailure) signalPassFailure(); |