summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorCameron Zwarich <zwarich@apple.com>2010-12-20 01:22:37 +0000
committerCameron Zwarich <zwarich@apple.com>2010-12-20 01:22:37 +0000
commitfc0c6b1ea9841341d159f9a7ef62c5047c91c2cc (patch)
treee7076d6502c19401e74664c78b1ae84af7a61d15 /llvm
parent46b9efcad75a056f7f77b34bfd488d842afa82e4 (diff)
downloadbcm5719-llvm-fc0c6b1ea9841341d159f9a7ef62c5047c91c2cc.tar.gz
bcm5719-llvm-fc0c6b1ea9841341d159f9a7ef62c5047c91c2cc.zip
Don't assume that an instruction ending a register's live range always reads
the register; it may be a dead def instead. Fixes PR8820. llvm-svn: 122218
Diffstat (limited to 'llvm')
-rw-r--r--llvm/lib/CodeGen/MachineVerifier.cpp22
1 files changed, 18 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/MachineVerifier.cpp b/llvm/lib/CodeGen/MachineVerifier.cpp
index 4025e296ce0..d0f251ed633 100644
--- a/llvm/lib/CodeGen/MachineVerifier.cpp
+++ b/llvm/lib/CodeGen/MachineVerifier.cpp
@@ -1072,10 +1072,24 @@ void MachineVerifier::verifyLiveIntervals() {
<< MBBStartIdx << '\n';
} else if (TargetRegisterInfo::isVirtualRegister(LI.reg) &&
!MI->readsVirtualRegister(LI.reg)) {
- // FIXME: Should we require a kill flag?
- report("Instruction killing live segment doesn't read register", MI);
- I->print(*OS);
- *OS << " in " << LI << '\n';
+ // A live range can end with either a redefinition, a kill flag on a
+ // use, or a dead flag on a def.
+ // FIXME: Should we check for each of these?
+ bool hasDeadDef = false;
+ for (MachineInstr::const_mop_iterator MOI = MI->operands_begin(),
+ MOE = MI->operands_end(); MOI != MOE; ++MOI) {
+ if (MOI->isReg() && MOI->isDef() && MOI->isDead()) {
+ hasDeadDef = true;
+ break;
+ }
+ }
+
+ if (!hasDeadDef) {
+ report("Instruction killing live segment neither defines nor reads "
+ "register", MI);
+ I->print(*OS);
+ *OS << " in " << LI << '\n';
+ }
}
}
OpenPOWER on IntegriCloud