summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorChandler Carruth <chandlerc@gmail.com>2012-01-15 08:41:35 +0000
committerChandler Carruth <chandlerc@gmail.com>2012-01-15 08:41:35 +0000
commitda22f30e721f1ce3ffc51ead2b06910b436a7d2e (patch)
tree7a65dc8f674c7ab3d39fe952c2b0540bab517850 /llvm
parentbd1530949d568ad5da39b9d33adef8a5d0552961 (diff)
downloadbcm5719-llvm-da22f30e721f1ce3ffc51ead2b06910b436a7d2e.tar.gz
bcm5719-llvm-da22f30e721f1ce3ffc51ead2b06910b436a7d2e.zip
Remove SetWorkingDirectory from the Process interface. Nothing in LLVM
or Clang is using this, and it would be hard to use it correctly given the thread hostility of the function. Also, it never checked the return which is rather dangerous with chdir. If someone was in fact using this, please let me know, as well as what the usecase actually is so that I can add it back and make it more correct and secure to use. (That said, it's never going to be "safe" per-se, but we could at least document the risks...) llvm-svn: 148211
Diffstat (limited to 'llvm')
-rw-r--r--llvm/include/llvm/Support/Process.h3
-rw-r--r--llvm/lib/Support/Unix/Process.inc4
-rw-r--r--llvm/lib/Support/Windows/Process.inc4
3 files changed, 0 insertions, 11 deletions
diff --git a/llvm/include/llvm/Support/Process.h b/llvm/include/llvm/Support/Process.h
index 27ef2670093..33799229ff3 100644
--- a/llvm/include/llvm/Support/Process.h
+++ b/llvm/include/llvm/Support/Process.h
@@ -138,9 +138,6 @@ namespace sys {
/// Resets the terminals colors, or returns an escape sequence to do so.
static const char *ResetColor();
-
- /// Change the program working directory to that given by \arg Path.
- static void SetWorkingDirectory(std::string Path);
/// @}
};
}
diff --git a/llvm/lib/Support/Unix/Process.inc b/llvm/lib/Support/Unix/Process.inc
index da440fd48f3..5cdb11ccebc 100644
--- a/llvm/lib/Support/Unix/Process.inc
+++ b/llvm/lib/Support/Unix/Process.inc
@@ -293,7 +293,3 @@ const char *Process::OutputBold(bool bg) {
const char *Process::ResetColor() {
return "\033[0m";
}
-
-void Process::SetWorkingDirectory(std::string Path) {
- ::chdir(Path.c_str());
-}
diff --git a/llvm/lib/Support/Windows/Process.inc b/llvm/lib/Support/Windows/Process.inc
index fe54eb1a797..913b0734ddc 100644
--- a/llvm/lib/Support/Windows/Process.inc
+++ b/llvm/lib/Support/Windows/Process.inc
@@ -220,8 +220,4 @@ const char *Process::ResetColor() {
return 0;
}
-void Process::SetWorkingDirectory(std::string Path) {
- ::_chdir(Path.c_str());
-}
-
}
OpenPOWER on IntegriCloud