diff options
| author | Nate Begeman <natebegeman@mac.com> | 2005-08-14 18:38:32 +0000 |
|---|---|---|
| committer | Nate Begeman <natebegeman@mac.com> | 2005-08-14 18:38:32 +0000 |
| commit | d5e739dcc212d3ec582fa31467f47b25e8346e08 (patch) | |
| tree | aae33dc7882ae1a72666653923b65283a583ac08 /llvm | |
| parent | e5394d453d2209ba5ce831c39b24c666ad710e28 (diff) | |
| download | bcm5719-llvm-d5e739dcc212d3ec582fa31467f47b25e8346e08.tar.gz bcm5719-llvm-d5e739dcc212d3ec582fa31467f47b25e8346e08.zip | |
Fix last night's PPC32 regressions by
1. Not selecting the false value of a select_cc in the false arm, which
isn't legal for nested selects.
2. Actually returning the node we created and Legalized in the FP_TO_UINT
Expander.
llvm-svn: 22789
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp | 1 | ||||
| -rw-r--r-- | llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp | 4 |
2 files changed, 2 insertions, 3 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp index b3317858917..3d13b21f224 100644 --- a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp @@ -1625,6 +1625,7 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) { False = DAG.getNode(ISD::XOR, NVT, False, DAG.getConstant(1ULL << ShiftAmt, NVT)); Result = LegalizeOp(DAG.getNode(ISD::SELECT, NVT, Tmp3, True, False)); + return Result; } else { assert(0 && "Do not know how to expand FP_TO_SINT yet!"); } diff --git a/llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp b/llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp index 80a405edc21..9831111eabc 100644 --- a/llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp +++ b/llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp @@ -2162,9 +2162,8 @@ unsigned ISel::SelectExpr(SDOperand N, bool Recording) { // If the False value only has one use, we can generate better code by // selecting it in the fallthrough basic block rather than here, which // increases register pressure. - bool FalseHasOneUse = N.getOperand(3).Val->hasOneUse(); unsigned TrueValue = SelectExpr(N.getOperand(2)); - unsigned FalseValue = FalseHasOneUse ? 0 : SelectExpr(N.getOperand(3)); + unsigned FalseValue = SelectExpr(N.getOperand(3)); unsigned CCReg = SelectCC(N.getOperand(0), N.getOperand(1), CC); Opc = getBCCForSetCC(CC); @@ -2195,7 +2194,6 @@ unsigned ISel::SelectExpr(SDOperand N, bool Recording) { // %FalseValue = ... // # fallthrough to sinkMBB BB = copy0MBB; - if (FalseHasOneUse) FalseValue = SelectExpr(N.getOperand(3)); // Update machine-CFG edges BB->addSuccessor(sinkMBB); |

