summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorFilipe Cabecinhas <me@filcab.net>2015-05-26 23:52:21 +0000
committerFilipe Cabecinhas <me@filcab.net>2015-05-26 23:52:21 +0000
commitbc6a90938426330a76ea1ec29d99ca7fcf46f447 (patch)
tree763355ab570ddc3ea9eda52d9d2f935ed7fc4914 /llvm
parent85fa7d5037fed8191ef67c2b4d954218b942a7d1 (diff)
downloadbcm5719-llvm-bc6a90938426330a76ea1ec29d99ca7fcf46f447.tar.gz
bcm5719-llvm-bc6a90938426330a76ea1ec29d99ca7fcf46f447.zip
[BitcodeReader] Make sure abbrev records have at least one operand (record code)
Bug found with AFL fuzz. llvm-svn: 238265
Diffstat (limited to 'llvm')
-rw-r--r--llvm/lib/Bitcode/Reader/BitstreamReader.cpp3
-rw-r--r--llvm/test/Bitcode/Inputs/invalid-abbrev-no-operands.bcbin0 -> 452 bytes
-rw-r--r--llvm/test/Bitcode/invalid.test5
3 files changed, 8 insertions, 0 deletions
diff --git a/llvm/lib/Bitcode/Reader/BitstreamReader.cpp b/llvm/lib/Bitcode/Reader/BitstreamReader.cpp
index 3b03f4b12b8..2d02549ce4e 100644
--- a/llvm/lib/Bitcode/Reader/BitstreamReader.cpp
+++ b/llvm/lib/Bitcode/Reader/BitstreamReader.cpp
@@ -282,6 +282,9 @@ void BitstreamCursor::ReadAbbrevRecord() {
} else
Abbv->Add(BitCodeAbbrevOp(E));
}
+
+ if (Abbv->getNumOperandInfos() == 0)
+ report_fatal_error("Abbrev record with no operands");
CurAbbrevs.push_back(Abbv);
}
diff --git a/llvm/test/Bitcode/Inputs/invalid-abbrev-no-operands.bc b/llvm/test/Bitcode/Inputs/invalid-abbrev-no-operands.bc
new file mode 100644
index 00000000000..29af122e94e
--- /dev/null
+++ b/llvm/test/Bitcode/Inputs/invalid-abbrev-no-operands.bc
Binary files differ
diff --git a/llvm/test/Bitcode/invalid.test b/llvm/test/Bitcode/invalid.test
index bd6e265cbb3..9c9d54fad6c 100644
--- a/llvm/test/Bitcode/invalid.test
+++ b/llvm/test/Bitcode/invalid.test
@@ -172,3 +172,8 @@ RUN: not llvm-dis -disable-output %p/Inputs/invalid-global-var-comdat-id.bc 2>&1
RUN: FileCheck --check-prefix=INVALID-GVCOMDAT-ID %s
INVALID-GVCOMDAT-ID: Invalid global variable comdat ID
+
+RUN: not llvm-dis -disable-output %p/Inputs/invalid-abbrev-no-operands.bc 2>&1 | \
+RUN: FileCheck --check-prefix=ABBREV-NO-OPS %s
+
+ABBREV-NO-OPS: Abbrev record with no operands
OpenPOWER on IntegriCloud