diff options
| author | Alexander Kornienko <alexfh@google.com> | 2017-07-26 10:14:55 +0000 |
|---|---|---|
| committer | Alexander Kornienko <alexfh@google.com> | 2017-07-26 10:14:55 +0000 |
| commit | a45648b9dd06e2567bf4f42d255fb8939f8e52bf (patch) | |
| tree | 4523712a18d7f742eb0b80b7ea105abc7d52b0f4 /llvm | |
| parent | 84941ef1585789956156d2067649f27a5b360ae8 (diff) | |
| download | bcm5719-llvm-a45648b9dd06e2567bf4f42d255fb8939f8e52bf.tar.gz bcm5719-llvm-a45648b9dd06e2567bf4f42d255fb8939f8e52bf.zip | |
Follow up for r307085: a better fix for a dangling StringRef.
llvm-svn: 309092
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/tools/llvm-readobj/COFFDumper.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/llvm/tools/llvm-readobj/COFFDumper.cpp b/llvm/tools/llvm-readobj/COFFDumper.cpp index 74c44116b12..8f668b9953a 100644 --- a/llvm/tools/llvm-readobj/COFFDumper.cpp +++ b/llvm/tools/llvm-readobj/COFFDumper.cpp @@ -1627,7 +1627,7 @@ void COFFDumper::printCOFFDirectives() { } } -static StringRef getBaseRelocTypeName(uint8_t Type) { +static std::string getBaseRelocTypeName(uint8_t Type) { switch (Type) { case COFF::IMAGE_REL_BASED_ABSOLUTE: return "ABSOLUTE"; case COFF::IMAGE_REL_BASED_HIGH: return "HIGH"; @@ -1636,11 +1636,7 @@ static StringRef getBaseRelocTypeName(uint8_t Type) { case COFF::IMAGE_REL_BASED_HIGHADJ: return "HIGHADJ"; case COFF::IMAGE_REL_BASED_ARM_MOV32T: return "ARM_MOV32(T)"; case COFF::IMAGE_REL_BASED_DIR64: return "DIR64"; - default: { - static std::string Result; - Result = "unknown (" + llvm::utostr(Type) + ")"; - return Result; - } + default: return "unknown (" + llvm::utostr(Type) + ")"; } } |
