summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorEli Friedman <eli.friedman@gmail.com>2011-04-09 09:11:09 +0000
committerEli Friedman <eli.friedman@gmail.com>2011-04-09 09:11:09 +0000
commit9cca0715aa9b8d49e55b8ba17d5e97cd5e8951d5 (patch)
treed12ba73c0b2f099e90cbf62a9fd236186c364180 /llvm
parentc5b20b5283485b515997c6cebf8ea57b4f8f91f8 (diff)
downloadbcm5719-llvm-9cca0715aa9b8d49e55b8ba17d5e97cd5e8951d5.tar.gz
bcm5719-llvm-9cca0715aa9b8d49e55b8ba17d5e97cd5e8951d5.zip
Add back a couple checks removed by r129128; the fact that an intitializer
is an array of structures doesn't imply it's a ConstantArray of ConstantStruct. llvm-svn: 129207
Diffstat (limited to 'llvm')
-rw-r--r--llvm/lib/Transforms/IPO/GlobalOpt.cpp10
-rw-r--r--llvm/test/Transforms/GlobalOpt/2011-04-09-EmptyGlobalCtors.ll5
2 files changed, 11 insertions, 4 deletions
diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
index 5b6ed2c9869..71d13edc96f 100644
--- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -1954,11 +1954,13 @@ GlobalVariable *GlobalOpt::FindGlobalCtors(Module &M) {
// only allowed to optimize the initializer if it is unique.
if (!GV->hasUniqueInitializer()) return 0;
- ConstantArray *CA = cast<ConstantArray>(GV->getInitializer());
-
+ ConstantArray *CA = dyn_cast<ConstantArray>(GV->getInitializer());
+ if (!CA) return 0;
+
for (User::op_iterator i = CA->op_begin(), e = CA->op_end(); i != e; ++i) {
- ConstantStruct *CS = cast<ConstantStruct>(*i);
-
+ ConstantStruct *CS = dyn_cast<ConstantStruct>(*i);
+ if (!CS) return 0;
+
if (isa<ConstantPointerNull>(CS->getOperand(1)))
continue;
diff --git a/llvm/test/Transforms/GlobalOpt/2011-04-09-EmptyGlobalCtors.ll b/llvm/test/Transforms/GlobalOpt/2011-04-09-EmptyGlobalCtors.ll
new file mode 100644
index 00000000000..321a487cc82
--- /dev/null
+++ b/llvm/test/Transforms/GlobalOpt/2011-04-09-EmptyGlobalCtors.ll
@@ -0,0 +1,5 @@
+; RUN: opt < %s -globalopt -disable-output
+
+%0 = type { i32, void ()* }
+@llvm.global_ctors = appending global [0 x %0] zeroinitializer
+
OpenPOWER on IntegriCloud