summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorFangrui Song <maskray@google.com>2019-04-10 05:31:21 +0000
committerFangrui Song <maskray@google.com>2019-04-10 05:31:21 +0000
commit7d4ad143715c22ef8e28157df26e7da29dc89cfa (patch)
tree07292a0b5f79695f4a91a0c043ab893c5e12a7fe /llvm
parentf8a74c18ec8869f42a5d48ad20c33e3021f68f26 (diff)
downloadbcm5719-llvm-7d4ad143715c22ef8e28157df26e7da29dc89cfa.tar.gz
bcm5719-llvm-7d4ad143715c22ef8e28157df26e7da29dc89cfa.zip
[llvm-objdump] Don't print trailing space in dumpBytes
In disassembly output, dumpBytes prints a space, followed by a tab printed by printInstr. Remove the extra space. llvm-svn: 358045
Diffstat (limited to 'llvm')
-rw-r--r--llvm/lib/MC/MCInstPrinter.cpp6
-rw-r--r--llvm/tools/llvm-objdump/llvm-objdump.cpp6
2 files changed, 8 insertions, 4 deletions
diff --git a/llvm/lib/MC/MCInstPrinter.cpp b/llvm/lib/MC/MCInstPrinter.cpp
index ab8773e7bbb..159f4070fe9 100644
--- a/llvm/lib/MC/MCInstPrinter.cpp
+++ b/llvm/lib/MC/MCInstPrinter.cpp
@@ -21,10 +21,14 @@ using namespace llvm;
void llvm::dumpBytes(ArrayRef<uint8_t> bytes, raw_ostream &OS) {
static const char hex_rep[] = "0123456789abcdef";
+ bool First = true;
for (char i: bytes) {
+ if (First)
+ First = false;
+ else
+ OS << ' ';
OS << hex_rep[(i & 0xF0) >> 4];
OS << hex_rep[i & 0xF];
- OS << ' ';
}
}
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index ceefe47404d..3ae72c71501 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -614,7 +614,7 @@ public:
if (MI)
IP.printInst(MI, OS, "", STI);
else
- OS << " <unknown>";
+ OS << "\t<unknown>";
}
};
PrettyPrinter PrettyPrinterInst;
@@ -629,7 +629,7 @@ public:
if (!NoShowRawInsn) {
OS << "\t";
dumpBytes(Bytes.slice(0, 4), OS);
- OS << format("%08" PRIx32, opcode);
+ OS << format("\t%08" PRIx32, opcode);
}
}
void printInst(MCInstPrinter &IP, const MCInst *MI, ArrayRef<uint8_t> Bytes,
@@ -768,7 +768,7 @@ public:
if (MI)
IP.printInst(MI, OS, "", STI);
else
- OS << " <unknown>";
+ OS << "\t<unknown>";
}
};
BPFPrettyPrinter BPFPrettyPrinterInst;
OpenPOWER on IntegriCloud