summaryrefslogtreecommitdiffstats
path: root/llvm
diff options
context:
space:
mode:
authorPhilip Reames <listmail@philipreames.com>2015-12-08 00:10:56 +0000
committerPhilip Reames <listmail@philipreames.com>2015-12-08 00:10:56 +0000
commit5ae3418ffecc754a72d5b71bf9d5c8bc95cde70a (patch)
tree732448217cfadf2981ce56514b030cfce45d4819 /llvm
parent3f5d2bc0bc9853c974850e824f091ddd8ea675bf (diff)
downloadbcm5719-llvm-5ae3418ffecc754a72d5b71bf9d5c8bc95cde70a.tar.gz
bcm5719-llvm-5ae3418ffecc754a72d5b71bf9d5c8bc95cde70a.zip
[PassManager] Tuning Memory Usage of AnalysisUsage
We were using unneccessarily large initial sizes for these SmallVectors. This was wasting around 50kb of memory for the O3 pipeline, even after the uniquing changes. We're still using around 20kb which is a bit much, but it's definitely better. This is about a 6% improvement in total O3 memory usage. Note: The raw data on structure size which were used to pick these thresholds can be found in the review thread. Differential Revision: http://reviews.llvm.org/D15244 llvm-svn: 254974
Diffstat (limited to 'llvm')
-rw-r--r--llvm/include/llvm/PassAnalysisSupport.h10
1 files changed, 8 insertions, 2 deletions
diff --git a/llvm/include/llvm/PassAnalysisSupport.h b/llvm/include/llvm/PassAnalysisSupport.h
index f6265b62cbf..492a4ef464f 100644
--- a/llvm/include/llvm/PassAnalysisSupport.h
+++ b/llvm/include/llvm/PassAnalysisSupport.h
@@ -36,11 +36,17 @@ namespace llvm {
///
class AnalysisUsage {
public:
- typedef SmallVector<AnalysisID, 32> VectorType;
+ typedef SmallVectorImpl<AnalysisID> VectorType;
private:
/// Sets of analyses required and preserved by a pass
- VectorType Required, RequiredTransitive, Preserved, Used;
+ // TODO: It's not clear that SmallVector is an appropriate data structure for
+ // this usecase. The sizes were picked to minimize wasted space, but are
+ // otherwise fairly meaningless.
+ SmallVector<AnalysisID, 8> Required;
+ SmallVector<AnalysisID, 2> RequiredTransitive;
+ SmallVector<AnalysisID, 2> Preserved;
+ SmallVector<AnalysisID, 0> Used;
bool PreservesAll;
public:
OpenPOWER on IntegriCloud