diff options
| author | Bill Wendling <isanbard@gmail.com> | 2011-03-30 21:37:19 +0000 |
|---|---|---|
| committer | Bill Wendling <isanbard@gmail.com> | 2011-03-30 21:37:19 +0000 |
| commit | 5034159c5ff5da6b455f779b3b56e6cbf89a59d4 (patch) | |
| tree | aaa24f0cdfdc8e496ae9675602778b999bd9ae07 /llvm | |
| parent | c640179166b973c6969d450ccb59b3c8bf5a5133 (diff) | |
| download | bcm5719-llvm-5034159c5ff5da6b455f779b3b56e6cbf89a59d4.tar.gz bcm5719-llvm-5034159c5ff5da6b455f779b3b56e6cbf89a59d4.zip | |
* The DSE code that tested for overlapping needed to take into account the fact
that one of the numbers is signed while the other is unsigned. This could lead
to a wrong result when the signed was promoted to an unsigned int.
* Add the data layout line to the testcase so that it will test the appropriate
thing.
Patch by David Terei!
llvm-svn: 128577
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/Transforms/DeadStoreElimination/2011-03-25-DSEMiscompile.ll | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp index f473cf5ca54..9f36a386917 100644 --- a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp +++ b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp @@ -361,8 +361,10 @@ static bool isCompleteOverwrite(const AliasAnalysis::Location &Later, // // |--earlier--| // |----- later ------| + // + // We have to be careful here as *Off is signed while *.Size is unsigned. if (EarlierOff >= LaterOff && - EarlierOff + Earlier.Size <= LaterOff + Later.Size) + uint64_t(EarlierOff - LaterOff) + Earlier.Size <= Later.Size) return true; // Otherwise, they don't completely overlap. diff --git a/llvm/test/Transforms/DeadStoreElimination/2011-03-25-DSEMiscompile.ll b/llvm/test/Transforms/DeadStoreElimination/2011-03-25-DSEMiscompile.ll index e268dd54140..079eec43bf8 100644 --- a/llvm/test/Transforms/DeadStoreElimination/2011-03-25-DSEMiscompile.ll +++ b/llvm/test/Transforms/DeadStoreElimination/2011-03-25-DSEMiscompile.ll @@ -1,5 +1,6 @@ ; RUN: opt < %s -basicaa -dse -S | FileCheck %s ; PR9561 +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128-n8:16:32" target triple = "i386-apple-darwin9.8" @A = external global [0 x i32] |
