diff options
author | Richard Trieu <rtrieu@google.com> | 2013-06-28 21:54:25 +0000 |
---|---|---|
committer | Richard Trieu <rtrieu@google.com> | 2013-06-28 21:54:25 +0000 |
commit | 4d18c9cc4e7f30a74703676c02e3399ebb2cb49f (patch) | |
tree | 6839cb7e65e5282ff1c6a2eccd981a7f12a41b30 /llvm | |
parent | 3192b2fceabc4d0d9fb91fcef59cde41749b66a0 (diff) | |
download | bcm5719-llvm-4d18c9cc4e7f30a74703676c02e3399ebb2cb49f.tar.gz bcm5719-llvm-4d18c9cc4e7f30a74703676c02e3399ebb2cb49f.zip |
Fix broken asserts that never fire.
Change assert("text") to assert(0 && "text"). The first case is a const char *
to bool conversion, which always evaluates to true, never triggering the
assert. The second case will always trigger the assert.
llvm-svn: 185227
Diffstat (limited to 'llvm')
-rw-r--r-- | llvm/include/llvm/TableGen/Record.h | 4 | ||||
-rw-r--r-- | llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/llvm/include/llvm/TableGen/Record.h b/llvm/include/llvm/TableGen/Record.h index a07898a955c..5bf4f4fc5d5 100644 --- a/llvm/include/llvm/TableGen/Record.h +++ b/llvm/include/llvm/TableGen/Record.h @@ -1799,9 +1799,9 @@ struct LessRecordRegister { unsigned LHSVal, RHSVal; if (LHSPart.second.getAsInteger(10, LHSVal)) - assert("Unable to convert LHS to integer."); + assert(0 && "Unable to convert LHS to integer."); if (RHSPart.second.getAsInteger(10, RHSVal)) - assert("Unable to convert RHS to integer."); + assert(0 && "Unable to convert RHS to integer."); if (LHSVal != RHSVal) return LHSVal < RHSVal; } diff --git a/llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp b/llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp index 36da6dfcc3d..3105665c940 100644 --- a/llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp +++ b/llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp @@ -179,7 +179,7 @@ void HexagonInstPrinter::printBranchOperand(const MCInst *MI, unsigned OpNo, raw_ostream &O) const { // Branches can take an immediate operand. This is used by the branch // selection pass to print $+8, an eight byte displacement from the PC. - assert("Unknown branch operand."); + assert(0 && "Unknown branch operand."); } void HexagonInstPrinter::printCallOperand(const MCInst *MI, unsigned OpNo, @@ -203,7 +203,7 @@ void HexagonInstPrinter::printSymbol(const MCInst *MI, unsigned OpNo, O << '#'; printOperand(MI, OpNo, O); } else { - assert("Unknown symbol operand"); + assert(0 && "Unknown symbol operand"); printOperand(MI, OpNo, O); } O << ')'; |