diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2015-02-16 08:41:08 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2015-02-16 08:41:08 +0000 |
| commit | 49b3d9bc84289c2eb8e097387e5c475ca7a22871 (patch) | |
| tree | fcc14a74f14a505a0ced25369625a3e5ce2a1ee0 /llvm | |
| parent | a3b0eb2f7fecd0fe15566b01215602a9784003ed (diff) | |
| download | bcm5719-llvm-49b3d9bc84289c2eb8e097387e5c475ca7a22871.tar.gz bcm5719-llvm-49b3d9bc84289c2eb8e097387e5c475ca7a22871.zip | |
AsmParser: Make sure GlobalVariables have sane types
llvm-svn: 229364
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/AsmParser/LLParser.cpp | 2 | ||||
| -rw-r--r-- | llvm/test/Assembler/gv-invalid-type.ll | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index 159bbccc87d..7818586dfa4 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -749,7 +749,7 @@ bool LLParser::ParseGlobal(const std::string &Name, LocTy NameLoc, return true; } - if (Ty->isFunctionTy() || Ty->isLabelTy()) + if (Ty->isFunctionTy() || !PointerType::isValidElementType(Ty)) return Error(TyLoc, "invalid type for global variable"); GlobalValue *GVal = nullptr; diff --git a/llvm/test/Assembler/gv-invalid-type.ll b/llvm/test/Assembler/gv-invalid-type.ll new file mode 100644 index 00000000000..bde04dab7a2 --- /dev/null +++ b/llvm/test/Assembler/gv-invalid-type.ll @@ -0,0 +1,4 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +@gv = global metadata undef +; CHECK: invalid type for global variable |
