diff options
| author | Dan Gohman <gohman@apple.com> | 2008-12-24 00:27:51 +0000 |
|---|---|---|
| committer | Dan Gohman <gohman@apple.com> | 2008-12-24 00:27:51 +0000 |
| commit | 198b8e78c3cea8f89d22c8fcb83cf22ae96d2aa3 (patch) | |
| tree | 90c4d699aaff4945e54391208422b17dd7199117 /llvm | |
| parent | 4b46b74ece972e86f2f9d31a8a6332881e389607 (diff) | |
| download | bcm5719-llvm-198b8e78c3cea8f89d22c8fcb83cf22ae96d2aa3.tar.gz bcm5719-llvm-198b8e78c3cea8f89d22c8fcb83cf22ae96d2aa3.zip | |
Fix a compiler-abort on a testcase where the stack-pointer is added to
a symbolic constant. This is unlikely to be intentional, but it
shouldn't crash the compiler.
llvm-svn: 61408
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/Target/X86/X86RegisterInfo.cpp | 19 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/2008-12-23-crazy-address.ll | 33 |
2 files changed, 46 insertions, 6 deletions
diff --git a/llvm/lib/Target/X86/X86RegisterInfo.cpp b/llvm/lib/Target/X86/X86RegisterInfo.cpp index b650d220507..a0d8b58b789 100644 --- a/llvm/lib/Target/X86/X86RegisterInfo.cpp +++ b/llvm/lib/Target/X86/X86RegisterInfo.cpp @@ -454,12 +454,19 @@ void X86RegisterInfo::eliminateFrameIndex(MachineBasicBlock::iterator II, // FrameIndex with base register with EBP. Add an offset to the offset. MI.getOperand(i).ChangeToRegister(BasePtr, false); - // Now add the frame object offset to the offset from EBP. Offset is a - // 32-bit integer. - int Offset = getFrameIndexOffset(MF, FrameIndex) + - (int)(MI.getOperand(i+3).getImm()); - - MI.getOperand(i+3).ChangeToImmediate(Offset); + // Now add the frame object offset to the offset from EBP. + if (MI.getOperand(i+3).isImm()) { + // Offset is a 32-bit integer. + int Offset = getFrameIndexOffset(MF, FrameIndex) + + (int)(MI.getOperand(i+3).getImm()); + + MI.getOperand(i+3).ChangeToImmediate(Offset); + } else { + // Offset is symbolic. This is extremely rare. + uint64_t Offset = getFrameIndexOffset(MF, FrameIndex) + + (uint64_t)MI.getOperand(i+3).getOffset(); + MI.getOperand(i+3).setOffset(Offset); + } } void diff --git a/llvm/test/CodeGen/X86/2008-12-23-crazy-address.ll b/llvm/test/CodeGen/X86/2008-12-23-crazy-address.ll new file mode 100644 index 00000000000..e53a91ec3a1 --- /dev/null +++ b/llvm/test/CodeGen/X86/2008-12-23-crazy-address.ll @@ -0,0 +1,33 @@ +; RUN: llvm-as < %s | llc -march=x86 -relocation-model=static | grep {lea.*X.*esp} | count 2 + +@X = external global [0 x i32] + +define void @foo() nounwind { +entry: + %Y = alloca i32 + call void @frob(i32* %Y) nounwind + %Y3 = bitcast i32* %Y to i8* + %ctg2 = getelementptr i8* %Y3, i32 ptrtoint ([0 x i32]* @X to i32) + %0 = ptrtoint i8* %ctg2 to i32 + call void @borf(i32 %0) nounwind + ret void +} + +define void @bar(i32 %i) nounwind { +entry: + %Y = alloca [10 x i32] + %0 = getelementptr [10 x i32]* %Y, i32 0, i32 0 + call void @frob(i32* %0) nounwind + %1 = getelementptr [0 x i32]* @X, i32 0, i32 %i + %2 = getelementptr [10 x i32]* %Y, i32 0, i32 0 + %3 = ptrtoint i32* %2 to i32 + %4 = bitcast i32* %1 to i8* + %ctg2 = getelementptr i8* %4, i32 %3 + %5 = ptrtoint i8* %ctg2 to i32 + call void @borf(i32 %5) nounwind + ret void +} + +declare void @frob(i32*) + +declare void @borf(i32) |

