diff options
| author | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2014-11-12 22:16:55 +0000 |
|---|---|---|
| committer | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2014-11-12 22:16:55 +0000 |
| commit | 0788d49a402570cdfb1cd2e108bf7c6e652e139a (patch) | |
| tree | 9591b6d1a4ab02ac8221f1c94162c0912e301de3 /llvm | |
| parent | f6f7d5d1dd0dae8c2f45aab6f2d96a3f31a256fa (diff) | |
| download | bcm5719-llvm-0788d49a402570cdfb1cd2e108bf7c6e652e139a.tar.gz bcm5719-llvm-0788d49a402570cdfb1cd2e108bf7c6e652e139a.zip | |
[CodeGenPrepare][AArch64] Fix a TLI legality check on iPTR to use a lowered instead.
Fixes PR21548. Related to PR20474.
llvm-svn: 221820
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/CodeGen/CodeGenPrepare.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/Transforms/CodeGenPrepare/AArch64/trunc-weird-user.ll | 19 |
2 files changed, 21 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index a5b2c96ed28..bea75a2f2ad 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -682,8 +682,8 @@ SinkShiftAndTruncate(BinaryOperator *ShiftI, Instruction *User, ConstantInt *CI, // FIXME: always querying the result type is just an // approximation; some nodes' legality is determined by the // operand or other means. There's no good way to find out though. - if (TLI.isOperationLegalOrCustom(ISDOpcode, - EVT::getEVT(TruncUser->getType(), true))) + if (TLI.isOperationLegalOrCustom( + ISDOpcode, TLI.getValueType(TruncUser->getType(), true))) continue; // Don't bother for PHI nodes. diff --git a/llvm/test/Transforms/CodeGenPrepare/AArch64/trunc-weird-user.ll b/llvm/test/Transforms/CodeGenPrepare/AArch64/trunc-weird-user.ll index 1a0878007b6..b4e6a409288 100644 --- a/llvm/test/Transforms/CodeGenPrepare/AArch64/trunc-weird-user.ll +++ b/llvm/test/Transforms/CodeGenPrepare/AArch64/trunc-weird-user.ll @@ -15,3 +15,22 @@ define %foo @test_merge(i32 %in) { %struct = insertvalue %foo undef, i8 %byte, 0 ret %"foo" %struct } + +define i64* @test_merge_PR21548(i32 %a, i64* %p1, i64* %p2, i64* %p3) { +; CHECK-LABEL: @test_merge_PR21548 + %as = lshr i32 %a, 3 + %Tr = trunc i32 %as to i1 + br i1 %Tr, label %BB2, label %BB3 + +BB2: + ; Similarly to above: + ; CodeGenPrepare was requesting the EVT for i8* to determine + ; whether the select user of the trunc was legal. This asserted. + +; CHECK: select i1 {{%.*}}, i64* %p1, i64* %p2 + %p = select i1 %Tr, i64* %p1, i64* %p2 + ret i64* %p + +BB3: + ret i64* %p3 +} |

