diff options
| author | Yaron Keren <yaron.keren@gmail.com> | 2015-03-18 10:17:07 +0000 |
|---|---|---|
| committer | Yaron Keren <yaron.keren@gmail.com> | 2015-03-18 10:17:07 +0000 |
| commit | 92e1b62d45aa5a3cbd67eaf5903165d7d8efeada (patch) | |
| tree | 1444da86136cbaaadf6bf12dd03c51eda0f728a3 /llvm/utils | |
| parent | 4a7baeab14a9f991752879bdc85ad4bf684cdf46 (diff) | |
| download | bcm5719-llvm-92e1b62d45aa5a3cbd67eaf5903165d7d8efeada.tar.gz bcm5719-llvm-92e1b62d45aa5a3cbd67eaf5903165d7d8efeada.zip | |
Remove many superfluous SmallString::str() calls.
Now that SmallString is a first-class citizen, most SmallString::str()
calls are not required. This patch removes a whole bunch of them, yet
there are lots more.
There are two use cases where str() is really needed:
1) To use one of StringRef member functions which is not available in
SmallString.
2) To convert to std::string, as StringRef implicitly converts while
SmallString do not. We may wish to change this, but it may introduce
ambiguity.
llvm-svn: 232622
Diffstat (limited to 'llvm/utils')
| -rw-r--r-- | llvm/utils/TableGen/FixedLenDecoderEmitter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/utils/TableGen/FixedLenDecoderEmitter.cpp b/llvm/utils/TableGen/FixedLenDecoderEmitter.cpp index 292a2b17c5b..c69b89b9bc0 100644 --- a/llvm/utils/TableGen/FixedLenDecoderEmitter.cpp +++ b/llvm/utils/TableGen/FixedLenDecoderEmitter.cpp @@ -1091,7 +1091,7 @@ unsigned FilterChooser::getDecoderIndex(DecoderSet &Decoders, // overkill for now, though. // Make sure the predicate is in the table. - Decoders.insert(Decoder.str()); + Decoders.insert(StringRef(Decoder)); // Now figure out the index for when we write out the table. DecoderSet::const_iterator P = std::find(Decoders.begin(), Decoders.end(), |

