diff options
| author | Chris Bieneman <beanz@apple.com> | 2016-10-03 04:48:22 +0000 |
|---|---|---|
| committer | Chris Bieneman <beanz@apple.com> | 2016-10-03 04:48:22 +0000 |
| commit | 7fac28f7ac0bfbabf889ddccec0523372dfd6a77 (patch) | |
| tree | fb3535e037ff11e91246fcf78517b79e5af350d3 /llvm/utils | |
| parent | dec815c8ecf041dfe6ef1c19d1217033bda8d54e (diff) | |
| download | bcm5719-llvm-7fac28f7ac0bfbabf889ddccec0523372dfd6a77.tar.gz bcm5719-llvm-7fac28f7ac0bfbabf889ddccec0523372dfd6a77.zip | |
[lit] Throw in unimplemented method (NFC)
Summary:
lit's `OneCommandFileTest` class implements an abstract method that
raises if called. However, it raises by referencing an undefined
symbol. Instead, raise explicitly by throwing a `NotImplementedError`.
This is clearer, and appeases Python linters.
Patch By Brian Gesiak!
Reviewers: ddunbar, echristo, beanz
Subscribers: llvm-commits, mehdi_amini
Differential Revision: https://reviews.llvm.org/D25170
llvm-svn: 283090
Diffstat (limited to 'llvm/utils')
| -rw-r--r-- | llvm/utils/lit/lit/formats/base.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/utils/lit/lit/formats/base.py b/llvm/utils/lit/lit/formats/base.py index 3d305cca5fc..6721d17e334 100644 --- a/llvm/utils/lit/lit/formats/base.py +++ b/llvm/utils/lit/lit/formats/base.py @@ -80,7 +80,7 @@ class OneCommandPerFileTest(TestFormat): yield test def createTempInput(self, tmp, test): - abstract + raise NotImplementedError('This is an abstract method.') def execute(self, test, litConfig): if test.config.unsupported: |
