summaryrefslogtreecommitdiffstats
path: root/llvm/utils
diff options
context:
space:
mode:
authorBob Wilson <bob.wilson@apple.com>2010-12-15 16:58:42 +0000
committerBob Wilson <bob.wilson@apple.com>2010-12-15 16:58:42 +0000
commit276f1ca89749399c07579d100cfb54718a216a64 (patch)
treeb3d30021e56a7c6f31e9e764ab802ce2fbd6b8db /llvm/utils
parent68fc88eca704d0f49d0b4dac1bf8dd2c88c6620c (diff)
downloadbcm5719-llvm-276f1ca89749399c07579d100cfb54718a216a64.tar.gz
bcm5719-llvm-276f1ca89749399c07579d100cfb54718a216a64.zip
Fix Neon intrinsic immediate range checking for some double-register operands.
Some quad-register intrinsics with lane operands only take a double-register operand for the vector containing the lane. The valid range of lane numbers is then half as big as you would expect from the quad-register type. Note: This currently has no effect because those intrinsics are now handled entirely in the header file using __builtin_shufflevector, which does its own range checking, but I want to use this for generating tests. llvm-svn: 121867
Diffstat (limited to 'llvm/utils')
-rw-r--r--llvm/utils/TableGen/NeonEmitter.cpp10
1 files changed, 7 insertions, 3 deletions
diff --git a/llvm/utils/TableGen/NeonEmitter.cpp b/llvm/utils/TableGen/NeonEmitter.cpp
index 1d311041325..0f80d7bcdfd 100644
--- a/llvm/utils/TableGen/NeonEmitter.cpp
+++ b/llvm/utils/TableGen/NeonEmitter.cpp
@@ -1213,10 +1213,11 @@ void NeonEmitter::emitIntrinsic(raw_ostream &OS, Record *R) {
OS << "\n";
}
-static unsigned RangeFromType(StringRef typestr) {
+static unsigned RangeFromType(const char mod, StringRef typestr) {
// base type to get the type string for.
bool quad = false, dummy = false;
char type = ClassifyType(typestr, quad, dummy, dummy);
+ type = ModType(mod, type, quad, dummy, dummy, dummy, dummy, dummy);
switch (type) {
case 'c':
@@ -1359,7 +1360,8 @@ void NeonEmitter::runHeader(raw_ostream &OS) {
// Functions which do not have an immediate do not need to have range
// checking code emitted.
- if (Proto.find('i') == std::string::npos)
+ size_t immPos = Proto.find('i');
+ if (immPos == std::string::npos)
continue;
SmallVector<StringRef, 16> TypeVec;
@@ -1386,7 +1388,9 @@ void NeonEmitter::runHeader(raw_ostream &OS) {
}
rangestr += "u = RFT(TV" + shiftstr + ")";
} else {
- rangestr = "u = " + utostr(RangeFromType(TypeVec[ti]));
+ // The immediate generally refers to a lane in the preceding argument.
+ assert(immPos > 0 && "unexpected immediate operand");
+ rangestr = "u = " + utostr(RangeFromType(Proto[immPos-1], TypeVec[ti]));
}
// Make sure cases appear only once by uniquing them in a string map.
namestr = MangleName(name, TypeVec[ti], ck);
OpenPOWER on IntegriCloud