diff options
| author | David Bolvansky <david.bolvansky@gmail.com> | 2019-07-29 17:41:00 +0000 |
|---|---|---|
| committer | David Bolvansky <david.bolvansky@gmail.com> | 2019-07-29 17:41:00 +0000 |
| commit | 45be5e477e9216363191a8ac9123bea4585cf14f (patch) | |
| tree | ee9f1fbdc3bb70e7069ac62e253459819dcf98b0 /llvm/utils/update_mca_test_checks.py | |
| parent | 72d00802d848e10ef1fc68564729d02d7a29546d (diff) | |
| download | bcm5719-llvm-45be5e477e9216363191a8ac9123bea4585cf14f.tar.gz bcm5719-llvm-45be5e477e9216363191a8ac9123bea4585cf14f.zip | |
[UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option
Summary:
The script is silent for the following issue:
FileCheck %s -check-prefix=CHECK,POPCOUNT
FileCheck will catch it later, but I think we can warn here too.
Now it warns:
./update_llc_test_checks.py file.ll
WARNING: Supplied prefix 'CHECK,POPCOUNT' is invalid. Prefix must contain only alphanumeric characters, hyphens and underscores. Did you mean --check-prefixes=CHECK,POPCOUNT?
Reviewers: lebedev.ri, spatel, RKSimon, craig.topper, nikic, gbedwell
Reviewed By: RKSimon
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64589
llvm-svn: 367244
Diffstat (limited to 'llvm/utils/update_mca_test_checks.py')
| -rwxr-xr-x | llvm/utils/update_mca_test_checks.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/utils/update_mca_test_checks.py b/llvm/utils/update_mca_test_checks.py index 87ac19b39ae..bbeca1d557b 100755 --- a/llvm/utils/update_mca_test_checks.py +++ b/llvm/utils/update_mca_test_checks.py @@ -116,6 +116,7 @@ def _get_run_infos(run_lines, args): _warn('could not split tool and filecheck commands: {}'.format(run_line)) continue + common.verify_filecheck_prefixes(filecheck_cmd) tool_basename = os.path.splitext(os.path.basename(args.llvm_mca_binary))[0] if not tool_cmd.startswith(tool_basename + ' '): |
