summaryrefslogtreecommitdiffstats
path: root/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h
diff options
context:
space:
mode:
authorAlexey Samsonov <samsonov@google.com>2013-11-18 09:31:53 +0000
committerAlexey Samsonov <samsonov@google.com>2013-11-18 09:31:53 +0000
commit49109a279c6b7b3622fa0227f6c77a96d075f718 (patch)
treed3ee87a1f6131cd29380a4ce6dd84aa232b2fa4c /llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h
parent6588c1a638032c8146be7f5d62a125f5d89dea76 (diff)
downloadbcm5719-llvm-49109a279c6b7b3622fa0227f6c77a96d075f718.tar.gz
bcm5719-llvm-49109a279c6b7b3622fa0227f6c77a96d075f718.zip
Revert r194865 and r194874.
This change is incorrect. If you delete virtual destructor of both a base class and a subclass, then the following code: Base *foo = new Child(); delete foo; will not cause the destructor for members of Child class. As a result, I observe plently of memory leaks. Notable examples I investigated are: ObjectBuffer and ObjectBufferStream, AttributeImpl and StringSAttributeImpl. llvm-svn: 194997
Diffstat (limited to 'llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h')
-rw-r--r--llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h b/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h
index 32fd9c65bfe..58f6cafa75f 100644
--- a/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h
+++ b/llvm/utils/unittest/googletest/include/gtest/internal/gtest-port.h
@@ -1116,7 +1116,7 @@ class Notification {
// problem.
class ThreadWithParamBase {
public:
- virtual ~ThreadWithParamBase();
+ virtual ~ThreadWithParamBase() {}
virtual void Run() = 0;
};
@@ -1290,7 +1290,7 @@ typedef GTestMutexLock MutexLock;
// ThreadLocalValueHolderBase.
class ThreadLocalValueHolderBase {
public:
- virtual ~ThreadLocalValueHolderBase();
+ virtual ~ThreadLocalValueHolderBase() {}
};
// Called by pthread to delete thread-local data stored by
OpenPOWER on IntegriCloud